-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super Cache: fix how the plugin uses apache_request_headers #39951
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Super Cache plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…et-apache-headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate the thorough testing instructions!
Testing was successful and code looks good.
If a site has disabled the function
apache_request_headers()
then WPSC will not display the "Rejected User Agents" textarea on the settings page. It would also cause a fatal error because the code checked if the function existed, before creating a fallback of the same name.Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack docker sh
/etc/php/8.2/fpm/php.ini
apache_request_headers
at the end.service php8.2-fpm restart