Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Improve compatibility with dark themes and outline styles #41518

Open
enejb opened this issue Feb 3, 2025 · 3 comments
Open

Forms: Improve compatibility with dark themes and outline styles #41518

enejb opened this issue Feb 3, 2025 · 3 comments
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@enejb
Copy link
Member

enejb commented Feb 3, 2025

Impacted plugin

Jetpack

Quick summary

Currently when you use a dark theme (such as twenty twenty five with the dark colour pattern) you end up with a buggy design of the Outline style.

See
Image

Steps to reproduce

  1. Activate the twenty twenty five theme. Select the "Evening" colour style.
  2. Add a form to the page and select the Outline option.

Notice that there is a white border under the label text.
Notice that the placeholder text is hardly visible.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

You could apply some custom css to fix this issue.

Platform (Simple and/or Atomic)

Simple, Self-hosted, Atomic

@enejb enejb added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Feb 3, 2025
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a [Type], a [Feature], and a [Pri] label?

@jeherve jeherve added Triaged and removed Needs triage Ticket needs to be triaged labels Feb 4, 2025
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Feb 4, 2025
@simison
Copy link
Member

simison commented Feb 4, 2025

Global styles support should improve this, @aaronrobertshaw ?

@aaronrobertshaw
Copy link
Contributor

Global styles support should improve this, @aaronrobertshaw ?

It might, in that it would allow theme authors to tweak the variation's inner block styles in theme.json. There's no UI for updating inner block styles for a block style variation in Global Styles for end users though. This was on the horizon in Gutenberg however the thinking was that we might need an overhaul of the Global Style IA.

If you're thinking that the form styles will automatically adapt to the selected theme. I don't think Global Styles will solve that out of the box.

Either way, I suspect the form and outline block style variation will need default style updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

5 participants