Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Field styles broken in the editor e.g. width, gap spacing etc. #41414

Closed
aaronrobertshaw opened this issue Jan 30, 2025 · 4 comments · Fixed by #41415
Closed

Forms: Field styles broken in the editor e.g. width, gap spacing etc. #41414

aaronrobertshaw opened this issue Jan 30, 2025 · 4 comments · Fixed by #41415
Assignees
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. Needs triage Ticket needs to be triaged [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated [Type] Bug When a feature is broken and / or not performing as intended

Comments

@aaronrobertshaw
Copy link
Contributor

Impacted plugin

Jetpack

Quick summary

It appears that #41348 broke field widths within the editor.

Checking out the commit prior to this one, field widths work as expected.

Before (13838d9) #41348 (fd115d1)
Image Image

Steps to reproduce

  1. Check out trunk
  2. Add a contact form to a post
  3. Select the name field and assign a 50% width
  4. Note the field remains 100% in the editor
  5. Apply 50% width to email field as well. Same result.
  6. Save post and view on the frontend
  7. Note the expected 50% width of the two fields

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

No response

@aaronrobertshaw aaronrobertshaw added [Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Package] Forms [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 30, 2025
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low labels Jan 30, 2025
@aaronrobertshaw
Copy link
Contributor Author

aaronrobertshaw commented Jan 30, 2025

It also looks like the spacing between fields in the form is now missing too.

The button width changed as well between those two commits but I think that might be how it's supposed to be?

@aaronrobertshaw aaronrobertshaw changed the title Forms: Field width not working in the editor Forms: Field widths and gap spacing not applied in editor Jan 30, 2025
@aaronrobertshaw aaronrobertshaw changed the title Forms: Field widths and gap spacing not applied in editor Forms: Field and button styles broken in the editor Jan 30, 2025
@talldan
Copy link
Contributor

talldan commented Jan 30, 2025

The button isn't supposed to be full width, but there are/were some issues with it prior to this bug.

#41139 is supposed to fix those issues.

I'll work on a fix for this and it should return the button to it's previous broken state instead of it's new broken state 😬 .

@aaronrobertshaw
Copy link
Contributor Author

#41139 is supposed to fix those issues.

Ah, there was my misunderstanding, I thought that had landed for some reason.

@aaronrobertshaw aaronrobertshaw changed the title Forms: Field and button styles broken in the editor Forms: Field styles broken in the editor e.g. width, gap spacing etc. Jan 30, 2025
@aaronrobertshaw
Copy link
Contributor Author

I've removed the reference to the button from the issue title in case it would cause confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. Needs triage Ticket needs to be triaged [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

3 participants