Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress block does not have an explicit line-height attribute #40899

Open
lailagmelo opened this issue Jan 8, 2025 · 2 comments
Open

VideoPress block does not have an explicit line-height attribute #40899

lailagmelo opened this issue Jan 8, 2025 · 2 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Low [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@lailagmelo
Copy link

Impacted plugin

VideoPress, Jetpack

Quick summary

The VideoPress block does not have an explicit line-height attribute and instead uses the attribute from the body tag, resulting in undesired space appearing below the block.

Steps to reproduce

  1. Place a VideoPress block in a new page, preferably inside a column block;
  2. Set all margin and padding to zero;
  3. Notice that there's still some spacing below the block.

A clear and concise description of what you expected to happen.

VideoPress block should have no spacing below it, when the bottom padding is set to zero.

What actually happened

VideoPress block displays some bottom spacing.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

If the user does not have anything other than the VideoPress block inside that column, you can ask them to manually set the line-height of the column to zero.

If they have text in the same column that might be impacted, the only workaround I know so far is to add the following CSS:

.jetpack-videopress-player__wrapper { line-height: 0; }

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

Ticket that brought this issue to our attention:

9247293-zd-a8c

@lailagmelo lailagmelo added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 8, 2025
@github-actions github-actions bot added [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Platform] Atomic [Platform] Simple [Pri] Low labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Support References

This comment is automatically generated. Please do not edit it.

  • 9247293-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 8, 2025
@jartes jartes added Triaged and removed Needs triage Ticket needs to be triaged labels Jan 9, 2025
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 9, 2025
@jartes
Copy link

jartes commented Jan 9, 2025

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes (with Jurassic Ninja)

📌 FINDINGS/SCREENSHOTS/VIDEO
Image

📌 ACTIONS

  • Triaged

👋🏻 @Automattic/nexus This is coming from a customer report. Can you review it at your earliest opportunity? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Low [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

3 participants