Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: general styling issues editor vs. published view - differences in styling between editor and published rendering #28316

Open
digitalwaveride opened this issue Jan 12, 2023 · 4 comments
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@digitalwaveride
Copy link

A simple example:

Label styling, input field styling (line-heights) ... are often not the same.

Image

For certain themes the differences are more drastic, example TwentyTwentyOne theme:

Image

Also discussed in:

#27837 (comment)
#27837 (comment)

@digitalwaveride digitalwaveride added [Feature] Contact Form [Type] Bug When a feature is broken and / or not performing as intended [Block] Contact Form Form block (also see Contact Form label) and removed [Feature] Contact Form labels Jan 12, 2023
@digitalwaveride digitalwaveride changed the title JP Forms - General styling issues editor vs. published view - Differences in styling between editor and published rendering - why? JP Forms - General styling issues editor vs. published view - Differences in styling between editor and published rendering Jan 12, 2023
@github-actions
Copy link
Contributor

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@sdixon194
Copy link
Contributor

Screenshot 2023-07-27 at 1 29 12 PM

This looks better to me now, but still has some differences like the bolded outline on the fields and still some slight line height differences.

@simison simison changed the title JP Forms - General styling issues editor vs. published view - Differences in styling between editor and published rendering Forms: general styling issues editor vs. published view - differences in styling between editor and published rendering Jan 2, 2025
@ntsekouras
Copy link
Member

Is this still valid? I couldn't spot any differences with a couple of themes.

If someone has more info about specific differences and a testing theme (and ensuring it's not style overrides from the used theme) it would be helpful. Otherwise maybe we should close this one?

@Robertght
Copy link

@ntsekouras I tested this using TwentytwentyOne on a self-hosted environment and I can confirm it's the same as shown in the screenshots above.

Image

In short we're missing the borders of the fields on this particular example.

Twentyseventeen looks fairly the same.

Here's another example with Varia: Automattic/themes#4825

@Robertght Robertght moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 13, 2025
@Robertght Robertght added Triaged and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

6 participants