Skip to content

Commit

Permalink
try: shouldn't we select wp on plugins?
Browse files Browse the repository at this point in the history
  • Loading branch information
@kraftbj
kraftbj committed Jan 21, 2025
1 parent 0d417f1 commit 92245e1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/tests.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,10 @@ jobs:
ANY_PLUGINS="$(jq --argjson changed "$CHANGED" -n '$changed | with_entries( select( .key | startswith( "plugins/" ) ) ) | any')"
echo "projects=${CHANGED}" >> "$GITHUB_OUTPUT"
echo "projects=${CHANGED}"
echo "any-plugins=${ANY_PLUGINS}" >> "$GITHUB_OUTPUT"
echo "any-plugins=${ANY_PLUGINS}"
- name: Select WordPress version
if: steps.changed.outputs.any-plugins != 'true' && matrix.wp != 'none'
if: steps.changed.outputs.any-plugins != 'false' && matrix.wp != 'none'
run: .github/files/select-wordpress-tag.sh

- name: Composer Install
Expand Down

1 comment on commit 92245e1

@anomiex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had steps.changed.outputs.any-plugins != 'true' because if it is true then .github/files/setup-wordpress-env.sh will handle it.

But now that you're needing the tag selected before the Composer Install step, it should probably be done unconditionally. And probably the call in .github/files/setup-wordpress-env.sh could be removed, since the unconditional call earlier should handle setting it.

Please sign in to comment.