Added a safeguard for invalid uploads causing fatals in API endpoints. (

#40726) * Added a special case for non-array data. * Changelog.
Automattic · Dec 30, 2024 · 55e87d5 · 55e87d5
1 parent 66197da
commit 55e87d5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/projects/plugins/jetpack/changelog/add-safeguard-for-invalid-uploads b/projects/plugins/jetpack/changelog/add-safeguard-for-invalid-uploads
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Jetpack API: Fixed a bug where invalid upload input caused a fatal error.
diff --git a/projects/plugins/jetpack/class.json-api-endpoints.php b/projects/plugins/jetpack/class.json-api-endpoints.php
@@ -2254,6 +2254,11 @@ public function handle_media_creation_v1_1( $media_files, $media_urls, $media_at
 
 				if ( ! $user_can_upload_files ) {
 					$media_id = new WP_Error( 'unauthorized', 'User cannot upload media.', 403 );
+				} elseif ( ! is_array( $media_item ) ) {
+					$media_id   = new WP_Error( 'invalid_input', 'Unable to process request.', 400 );
+					$media_item = array(
+						'name' => 'invalid_file',
+					);
 				} elseif ( $this->media_item_is_free_video_mobile_upload_and_too_long( $media_item ) ) {
 					$media_id = new WP_Error( 'upload_video_length', 'Video uploads longer than 5 minutes require a paid plan.', 400 );
 				} else {