diff --git a/projects/packages/connection/.phan/baseline.php b/projects/packages/connection/.phan/baseline.php index a405b30cfd3c8..fd61210a7bcf7 100644 --- a/projects/packages/connection/.phan/baseline.php +++ b/projects/packages/connection/.phan/baseline.php @@ -11,18 +11,18 @@ // # Issue statistics: // PhanParamTooMany : 40+ occurrences // PhanTypeMismatchArgument : 40+ occurrences - // PhanDeprecatedFunction : 15+ occurrences // PhanPluginDuplicateConditionalNullCoalescing : 15+ occurrences // PhanTypeMismatchReturn : 15+ occurrences // PhanTypeMismatchArgumentProbablyReal : 9 occurrences // PhanTypeMismatchPropertyProbablyReal : 9 occurrences // PhanNoopNew : 8 occurrences // PhanTypeMismatchReturnProbablyReal : 8 occurrences - // PhanRedundantCondition : 5 occurrences + // PhanRedundantCondition : 6 occurrences // PhanTypeArraySuspiciousNullable : 5 occurrences // PhanTypeMismatchDefault : 5 occurrences // PhanTypeMismatchArgumentInternal : 3 occurrences // PhanTypeObjectUnsetDeclaredProperty : 3 occurrences + // PhanDeprecatedFunction : 2 occurrences // PhanNonClassMethodCall : 2 occurrences // PhanPluginUnreachableCode : 2 occurrences // PhanPossiblyUndeclaredVariable : 2 occurrences @@ -60,19 +60,15 @@ 'src/sso/class-user-admin.php' => ['PhanPluginUnreachableCode', 'PhanTypeMismatchArgument'], 'src/webhooks/class-authorize-redirect.php' => ['PhanUndeclaredClassMethod'], 'tests/php/test-class-nonce-handler.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanTypeMismatchArgument'], - 'tests/php/test-class-webhooks.php' => ['PhanDeprecatedFunction'], - 'tests/php/test-partner-coupon.php' => ['PhanDeprecatedFunction'], 'tests/php/test-rest-endpoints.php' => ['PhanNoopNew', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'], - 'tests/php/test-tracking.php' => ['PhanDeprecatedFunction'], 'tests/php/test_Error_Handler.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument'], 'tests/php/test_Manager_integration.php' => ['PhanParamTooMany'], 'tests/php/test_Manager_unit.php' => ['PhanDeprecatedFunction', 'PhanParamTooMany', 'PhanTypeArraySuspiciousNullable', 'PhanTypeObjectUnsetDeclaredProperty'], - 'tests/php/test_Rest_Authentication.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgument'], + 'tests/php/test_Rest_Authentication.php' => ['PhanTypeMismatchArgument'], 'tests/php/test_Server_Sandbox.php' => ['PhanTypeArraySuspiciousNullable'], 'tests/php/test_Signature.php' => ['PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/test_Tokens.php' => ['PhanDeprecatedFunction', 'PhanTypeObjectUnsetDeclaredProperty'], - 'tests/php/test_jetpack_xmlrpc_server.php' => ['PhanDeprecatedFunction', 'PhanPluginSimplifyExpressionBool', 'PhanTypeMismatchArgument'], - 'tests/php/test_package_version_tracker.php' => ['PhanDeprecatedFunction'], + 'tests/php/test_Tokens.php' => ['PhanTypeObjectUnsetDeclaredProperty'], + 'tests/php/test_jetpack_xmlrpc_server.php' => ['PhanPluginSimplifyExpressionBool', 'PhanTypeMismatchArgument'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/packages/forms/.phan/baseline.php b/projects/packages/forms/.phan/baseline.php index d7a12292e960f..86ad86c26202b 100644 --- a/projects/packages/forms/.phan/baseline.php +++ b/projects/packages/forms/.phan/baseline.php @@ -14,7 +14,6 @@ // PhanTypeMismatchReturnProbablyReal : 9 occurrences // PhanTypeMismatchArgumentInternal : 7 occurrences // PhanTypeMismatchArgumentProbablyReal : 6 occurrences - // PhanDeprecatedFunction : 5 occurrences // PhanRedundantCondition : 4 occurrences // PhanTypePossiblyInvalidDimOffset : 3 occurrences // PhanPluginRedundantAssignment : 2 occurrences @@ -42,7 +41,6 @@ 'src/dashboard/class-dashboard-view-switch.php' => ['PhanUnreferencedUseNormal'], 'src/service/class-google-drive.php' => ['PhanTypeMismatchReturnProbablyReal'], 'tests/php/contact-form/test-class.contact-form-plugin.php' => ['PhanPluginMixedKeyNoKey'], - 'tests/php/contact-form/test-class.contact-form.php' => ['PhanDeprecatedFunction'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/packages/publicize/.phan/baseline.php b/projects/packages/publicize/.phan/baseline.php index b3e516345e315..276871afd3219 100644 --- a/projects/packages/publicize/.phan/baseline.php +++ b/projects/packages/publicize/.phan/baseline.php @@ -9,17 +9,17 @@ */ return [ // # Issue statistics: - // PhanDeprecatedFunction : 9 occurrences - // PhanPluginDuplicateConditionalNullCoalescing : 7 occurrences // PhanTypeMismatchArgument : 7 occurrences + // PhanPluginDuplicateConditionalNullCoalescing : 6 occurrences // PhanTypeMismatchArgumentNullable : 3 occurrences - // PhanPluginMixedKeyNoKey : 2 occurrences + // PhanDeprecatedFunction : 2 occurrences // PhanPossiblyUndeclaredVariable : 2 occurrences // PhanTypeMismatchReturnProbablyReal : 2 occurrences // PhanTypeMissingReturn : 2 occurrences // PhanImpossibleCondition : 1 occurrence // PhanParamSignatureMismatch : 1 occurrence // PhanPluginDuplicateExpressionAssignmentOperation : 1 occurrence + // PhanPluginMixedKeyNoKey : 1 occurrence // PhanPluginSimplifyExpressionBool : 1 occurrence // PhanSuspiciousMagicConstant : 1 occurrence // PhanTypeMismatchArgumentNullableInternal : 1 occurrence @@ -41,10 +41,8 @@ 'src/social-image-generator/class-rest-settings-controller.php' => ['PhanPluginMixedKeyNoKey'], 'src/social-image-generator/class-settings.php' => ['PhanPluginDuplicateConditionalNullCoalescing'], 'src/social-image-generator/class-setup.php' => ['PhanTypeMismatchArgumentNullable'], - 'tests/php/jetpack-social-settings/test-jetpack-social-settings.php' => ['PhanDeprecatedFunction'], - 'tests/php/test-connections-post-field.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgument'], + 'tests/php/test-connections-post-field.php' => ['PhanTypeMismatchArgument'], 'tests/php/test-publicize-og-optimization.php' => ['PhanDeprecatedFunction'], - 'tests/php/test-social-image-generator/test-post-settings.php' => ['PhanDeprecatedFunction'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/packages/stats/.phan/baseline.php b/projects/packages/stats/.phan/baseline.php index 8c7b82fade56e..20e29a09c4233 100644 --- a/projects/packages/stats/.phan/baseline.php +++ b/projects/packages/stats/.phan/baseline.php @@ -12,7 +12,6 @@ // PhanParamTooMany : 7 occurrences // PhanTypeVoidAssignment : 4 occurrences // PhanPluginDuplicateConditionalNullCoalescing : 2 occurrences - // PhanDeprecatedFunction : 1 occurrence // PhanTypeMismatchReturn : 1 occurrence // Currently, file_suppressions and directory_suppressions are the only supported suppressions @@ -21,7 +20,6 @@ 'src/class-wpcom-stats.php' => ['PhanTypeMismatchReturn'], 'tests/php/test-main.php' => ['PhanParamTooMany', 'PhanTypeVoidAssignment'], 'tests/php/test-options.php' => ['PhanTypeVoidAssignment'], - 'tests/php/test-wpcom-stats.php' => ['PhanDeprecatedFunction'], 'tests/php/test-xmlrpc-provider.php' => ['PhanParamTooMany', 'PhanTypeVoidAssignment'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. diff --git a/projects/packages/status/.phan/baseline.php b/projects/packages/status/.phan/baseline.php index 32fce6e860dcb..4d814abb8a776 100644 --- a/projects/packages/status/.phan/baseline.php +++ b/projects/packages/status/.phan/baseline.php @@ -14,7 +14,6 @@ // PhanPluginDuplicateConditionalNullCoalescing : 2 occurrences // PhanPluginSimplifyExpressionBool : 2 occurrences // PhanRedefineFunction : 2 occurrences - // PhanDeprecatedFunction : 1 occurrence // PhanParamTooMany : 1 occurrence // PhanPluginRedundantAssignment : 1 occurrence // PhanRedundantCondition : 1 occurrence @@ -34,7 +33,7 @@ 'src/class-status.php' => ['PhanRedundantCondition', 'PhanUndeclaredFunction'], 'tests/php/bootstrap.php' => ['PhanRedefineFunction', 'PhanTypeMismatchReturnProbablyReal'], 'tests/php/test-host.php' => ['PhanParamTooMany'], - 'tests/php/test-status.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgumentInternal'], + 'tests/php/test-status.php' => ['PhanTypeMismatchArgumentInternal'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/packages/sync/.phan/baseline.php b/projects/packages/sync/.phan/baseline.php index e67e8aeb060c1..49e36b2f4fc0c 100644 --- a/projects/packages/sync/.phan/baseline.php +++ b/projects/packages/sync/.phan/baseline.php @@ -19,7 +19,6 @@ // PhanPluginSimplifyExpressionBool : 9 occurrences // PhanPossiblyUndeclaredVariable : 8 occurrences // PhanPluginDuplicateSwitchCaseLooseEquality : 6 occurrences - // PhanUndeclaredTypeReturnType : 6 occurrences // PhanNonClassMethodCall : 5 occurrences // PhanRedundantCondition : 4 occurrences // PhanTypeExpectedObjectPropAccess : 4 occurrences @@ -34,7 +33,6 @@ // PhanTypeMismatchReturnNullable : 2 occurrences // PhanTypePossiblyInvalidDimOffset : 2 occurrences // PhanTypeSuspiciousStringExpression : 2 occurrences - // PhanDeprecatedFunction : 1 occurrence // PhanNoopNew : 1 occurrence // PhanParamTooManyCallable : 1 occurrence // PhanPluginUseReturnValueInternalKnown : 1 occurrence @@ -83,7 +81,7 @@ 'src/modules/class-woocommerce.php' => ['PhanTypeMismatchReturnProbablyReal'], 'src/replicastore/class-table-checksum.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchPropertyDefault', 'PhanTypeMismatchPropertyProbablyReal'], 'tests/php/test-actions.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/test-dedicated-sender.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredProperty'], + 'tests/php/test-dedicated-sender.php' => ['PhanUndeclaredProperty'], 'tests/php/test-rest-endpoints.php' => ['PhanNoopNew', 'PhanTypeMismatchReturn'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. diff --git a/projects/packages/waf/.phan/baseline.php b/projects/packages/waf/.phan/baseline.php index f80ad2b6433a7..327b501c60128 100644 --- a/projects/packages/waf/.phan/baseline.php +++ b/projects/packages/waf/.phan/baseline.php @@ -9,13 +9,11 @@ */ return [ // # Issue statistics: - // PhanDeprecatedFunction : 9 occurrences - // PhanTypeMismatchArgument : 9 occurrences + // PhanTypeMismatchArgument : 8 occurrences // PhanNoopNew : 6 occurrences // PhanTypeMismatchDefault : 5 occurrences // PhanTypeMismatchReturn : 5 occurrences // PhanTypeMismatchReturnProbablyReal : 5 occurrences - // PhanUndeclaredConstant : 5 occurrences // PhanPluginDuplicateConditionalNullCoalescing : 4 occurrences // PhanRedefineFunction : 4 occurrences // PhanTypeMismatchArgumentInternal : 4 occurrences @@ -26,7 +24,6 @@ // PhanTypeArraySuspiciousNullable : 2 occurrences // PhanTypeMismatchArgumentNullable : 2 occurrences // PhanCoalescingNeverNull : 1 occurrence - // PhanImpossibleTypeComparison : 1 occurrence // PhanNonClassMethodCall : 1 occurrence // PhanPluginInvalidPregRegex : 1 occurrence // PhanTypeComparisonToArray : 1 occurrence @@ -34,6 +31,7 @@ // PhanTypeInvalidDimOffset : 1 occurrence // PhanTypeMismatchArgumentNullableInternal : 1 occurrence // PhanTypeMismatchProperty : 1 occurrence + // PhanUndeclaredConstant : 1 occurrence // Currently, file_suppressions and directory_suppressions are the only supported suppressions 'file_suppressions' => [ @@ -51,7 +49,7 @@ 'tests/php/unit/functions-wordpress.php' => ['PhanRedefineFunction'], 'tests/php/unit/test-waf-operators.php' => ['PhanTypeMismatchArgumentInternal'], 'tests/php/unit/test-waf-runtime-targets.php' => ['PhanPluginRedundantAssignment'], - 'tests/php/unit/test-waf-standalone-bootstrap.php' => ['PhanDeprecatedFunction', 'PhanNoopNew'], + 'tests/php/unit/test-waf-standalone-bootstrap.php' => ['PhanNoopNew'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/plugins/jetpack/.phan/baseline.php b/projects/plugins/jetpack/.phan/baseline.php index 4547a6db5e39c..32c0d1270c42a 100644 --- a/projects/plugins/jetpack/.phan/baseline.php +++ b/projects/plugins/jetpack/.phan/baseline.php @@ -15,9 +15,9 @@ // PhanTypeMismatchArgumentProbablyReal : 200+ occurrences // PhanTypeMismatchReturn : 150+ occurrences // PhanTypeMismatchReturnProbablyReal : 130+ occurrences - // PhanDeprecatedFunction : 120+ occurrences // PhanTypePossiblyInvalidDimOffset : 95+ occurrences // PhanRedundantCondition : 70+ occurrences + // PhanDeprecatedFunction : 65+ occurrences // PhanPossiblyUndeclaredVariable : 60+ occurrences // PhanTypeArraySuspiciousNullable : 60+ occurrences // PhanRedefineFunction : 55+ occurrences @@ -487,23 +487,19 @@ 'sal/class.json-api-site-jetpack.php' => ['PhanParamSignatureMismatch'], 'sal/class.json-api-token.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgumentProbablyReal'], 'src/class-jetpack-modules-overrides.php' => ['PhanRedundantCondition'], - 'tests/php/3rd-party/test_class-domain-mapping.php' => ['PhanDeprecatedFunction'], 'tests/php/3rd-party/test_class.jetpack-amp-support.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/_inc/lib/test-class-jetpack-blogging-prompts.php' => ['PhanTypeMismatchArgumentNullable'], - 'tests/php/_inc/lib/test-class-jetpack-podcast-helper.php' => ['PhanDeprecatedFunction'], 'tests/php/_inc/lib/test_class.rest-api-authentication.php' => ['PhanParamTooMany', 'PhanPluginDuplicateConditionalNullCoalescing'], 'tests/php/_inc/lib/test_class.rest-api-endpoints.php' => ['PhanParamTooMany', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeInvalidLeftOperandOfAdd', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'], 'tests/php/core-api/test_class-wpcom-rest-field-controller.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/core-api/test_class.jetpack-core-api-xmlrpc-consumer-endpoint.php' => ['PhanDeprecatedFunction'], 'tests/php/core-api/wpcom-endpoints/test-class-wpcom-rest-api-v2-endpoint-admin-menu.php' => ['PhanPluginMixedKeyNoKey', 'PhanTypeArraySuspiciousNullable', 'PhanTypeMismatchReturn'], 'tests/php/core-api/wpcom-endpoints/test-class-wpcom-rest-api-v2-endpoint-external-media.php' => ['PhanTypeExpectedObjectPropAccess', 'PhanTypeMismatchArgument'], 'tests/php/core-api/wpcom-endpoints/test-class-wpcom-rest-api-v2-endpoint-publicize-share-post.php' => ['PhanTypeMismatchArgument'], - 'tests/php/core-api/wpcom-fields/class-test-wpcom-rest-api-v2-attachment-videopress-data.php' => ['PhanDeprecatedFunction'], - 'tests/php/core-api/wpcom-fields/test-attachment-fields-videopress.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/core-api/wpcom-fields/test-post-fields-publicize-connections.php' => ['PhanDeprecatedFunction', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeComparisonToArray', 'PhanTypeMismatchPropertyProbablyReal'], + 'tests/php/core-api/wpcom-fields/test-attachment-fields-videopress.php' => ['PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/core-api/wpcom-fields/test-post-fields-publicize-connections.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeComparisonToArray', 'PhanTypeMismatchPropertyProbablyReal'], 'tests/php/extensions/blocks/premium-content/test_class.jetpack-premium-content.php' => ['PhanDeprecatedProperty', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMissingReturn', 'PhanUndeclaredMethod'], 'tests/php/general/test-class.jetpack-gutenberg.php' => ['PhanPluginDuplicateAdjacentStatement'], - 'tests/php/general/test_class.jetpack-client-server.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/general/test_class.jetpack-client-server.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/general/test_class.jetpack-user-agent.php' => ['PhanDeprecatedFunction'], 'tests/php/general/test_class.jetpack-xmlrpc-server.php' => ['PhanDeprecatedFunction', 'PhanPluginSimplifyExpressionBool', 'PhanRedundantCondition'], 'tests/php/general/test_class.jetpack.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanTypeMismatchPropertyDefault'], @@ -514,10 +510,10 @@ 'tests/php/json-api/test_class.json-api-platform-jetpack.php' => ['PhanTypeMismatchArgument'], 'tests/php/media/test-class.jetpack-media-extractor.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/media/test-class.jetpack-post-images.php' => ['PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/modules/geo-location/test_class.jetpack-geo-location.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/modules/geo-location/test_class.jetpack-geo-location.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/modules/photon/test_class.jetpack-photon-static-asset-cdn.php' => ['PhanTypeMismatchProperty'], 'tests/php/modules/post-by-email/test-class.post-by-email-api.php' => ['PhanParamTooMany'], - 'tests/php/modules/publicize/test_class.publicize.php' => ['PhanDeprecatedFunction', 'PhanPluginDuplicateConditionalNullCoalescing'], + 'tests/php/modules/publicize/test_class.publicize.php' => ['PhanPluginDuplicateConditionalNullCoalescing'], 'tests/php/modules/sharedaddy/test-class.recaptcha.php' => ['PhanDeprecatedClass'], 'tests/php/modules/shortcodes/test-class.archives.php' => ['PhanPluginDuplicateAdjacentStatement'], 'tests/php/modules/shortcodes/test-class.getty.php' => ['PhanPluginInvalidPregRegex'], @@ -535,7 +531,7 @@ 'tests/php/modules/widgets/test_contact-info-widget.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/modules/widgets/test_wordpress-post-widget.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/class-test-jetpack-sync-search.php' => ['PhanStaticCallToNonStatic', 'PhanTypeMismatchArgumentInternal'], - 'tests/php/sync/class-wp-test-jetpack-sync-queue-base-tests.php' => ['PhanDeprecatedFunction', 'PhanParamTooMany', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/sync/class-wp-test-jetpack-sync-queue-base-tests.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/server/class.jetpack-sync-server-eventstore.php' => ['PhanPluginDuplicateConditionalNullCoalescing'], 'tests/php/sync/server/class.jetpack-sync-test-object-factory.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/server/class.jetpack-sync-test-replicastore.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeInvalidLeftOperandOfAdd'], @@ -551,10 +547,10 @@ 'tests/php/sync/test_class.jetpack-sync-menus.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/test_class.jetpack-sync-meta.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument'], 'tests/php/sync/test_class.jetpack-sync-modules-stats.php' => ['PhanParamTooMany'], - 'tests/php/sync/test_class.jetpack-sync-posts.php' => ['PhanDeprecatedFunction', 'PhanNoopNew', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeExpectedObjectPropAccess', 'PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/sync/test_class.jetpack-sync-posts.php' => ['PhanNoopNew', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeExpectedObjectPropAccess', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/test_class.jetpack-sync-queue-custom-table.php' => ['PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/test_class.jetpack-sync-queue-options-table.php' => ['PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/sync/test_class.jetpack-sync-queue.php' => ['PhanDeprecatedFunction', 'PhanParamTooMany', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], + 'tests/php/sync/test_class.jetpack-sync-queue.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/test_class.jetpack-sync-sender.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanTypeMismatchArgumentProbablyReal'], 'tests/php/sync/test_class.jetpack-sync-term-relationships.php' => ['PhanPluginUnreachableCode'], 'tests/php/sync/test_class.jetpack-sync-themes.php' => ['PhanPluginDuplicateAdjacentStatement'], @@ -563,7 +559,6 @@ 'tests/php/sync/test_class.jetpack-sync-wp_super_cache.php' => ['PhanPluginSimplifyExpressionBool', 'PhanTypeArraySuspiciousNullable'], 'tests/php/sync/test_interface.jetpack-sync-replicastore.php' => ['PhanRedundantConditionInLoop', 'PhanTypeObjectUnsetDeclaredProperty'], 'tests/php/test_class.functions.opengraph.php' => ['PhanTypeMismatchArgumentProbablyReal'], - 'tests/php/test_deprecation.php' => ['PhanDeprecatedFunction'], 'tools/build-asset-cdn-json.php' => ['PhanTypeArraySuspiciousNullable', 'PhanTypeMismatchArgument'], 'uninstall.php' => ['PhanTypeMismatchArgumentInternal'], ], diff --git a/projects/plugins/social/.phan/baseline.php b/projects/plugins/social/.phan/baseline.php index ae4fef7e528b8..72cefa8683138 100644 --- a/projects/plugins/social/.phan/baseline.php +++ b/projects/plugins/social/.phan/baseline.php @@ -10,7 +10,6 @@ return [ // # Issue statistics: // PhanUndeclaredProperty : 20+ occurrences - // PhanDeprecatedFunction : 1 occurrence // PhanNoopNew : 1 occurrence // PhanTypeMismatchArgument : 1 occurrence // PhanTypeMismatchReturnProbablyReal : 1 occurrence @@ -20,7 +19,7 @@ 'jetpack-social.php' => ['PhanNoopNew'], 'src/class-jetpack-social.php' => ['PhanTypeMismatchReturnProbablyReal'], 'src/class-note.php' => ['PhanTypeMismatchArgument'], - 'tests/php/test-class-jetpack-social.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredProperty'], + 'tests/php/test-class-jetpack-social.php' => ['PhanUndeclaredProperty'], 'tests/php/test-class-meta-tags.php' => ['PhanUndeclaredProperty'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.