-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode-plugin): Add CMake Support #360
Conversation
I wasn't clear enough, sorry about that. The bigger issue was that there would inevitably be duplicate information (once in the CHANGELOG.md and once on the actual release page in GitHub. Updating both is redundant. We can return the |
Okay, I understand. It's just that the release pages are for Harper in general, while the If you'd really rather not have the duplication, I think it's alright to not have the changelog. Albeit less convenient, I think most users who would want to view it can probably find their way to the release pages and parse them on their own. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0) [Compare Source](Automattic/harper@v0.15.0...v0.16.0) #### What's Changed - [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341). - [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519). - [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html) - [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131) - [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195) - [A rule for variations of the word “your” was added](Automattic/harper@113bc36). - fix the nvim-lspconfig link by [@​wadsaek](https://github.com/wadsaek) in Automattic/harper#367 - docs: added Scoop instructions by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361 - Enable LTO and codegen-units = 1 in the Release profile by [@​zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363 - feat([#​331](Automattic/harper#331)): Literate Haskell Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#344 - build(deps): bump dirs from 5.0.1 to 6.0.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#372 - build(deps): bump tokio from 1.42.0 to 1.43.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#371 - build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#369 - feat: Typst Language Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#302 - build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#368 - feat(core): create new linter for dollar sign placement by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376 - refactor: Harper-ls Error-Handling Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#349 - feat([#​104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#305 - feat(harper.js): added ability to configure the markup language by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379 - feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@​mcecode](https://github.com/mcecode) in Automattic/harper#388 #### New Contributors - [@​wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367 - [@​elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361 - [@​zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363 **Full Changelog**: Automattic/harper@v0.15.0...v0.16.0 ### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0) [Compare Source](Automattic/harper@v0.14.0...v0.15.0) #### What's Changed - Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)). - Fixed issues with parsing hostnames - Added a variety of available `Pattern`s for downstream use - Update +page.md by [@​aminwhat](https://github.com/aminwhat) in Automattic/harper#347 - feat: Add technical words to dictionary by [@​claydugo](https://github.com/claydugo) in Automattic/harper#343 - refactor: remove raw hashes that are unnecessary by [@​hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324 - feat: Span View Command Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#340 - Address "one" for indefinite article rule by [@​claydugo](https://github.com/claydugo) in Automattic/harper#359 - feat: Add support for cmake files by [@​alcroito](https://github.com/alcroito) in Automattic/harper#353 - build(deps): bump itertools from 0.13.0 to 0.14.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#357 - feat(harper-ls): remove deleted file/s diagnostics by [@​mcecode](https://github.com/mcecode) in Automattic/harper#304 - feat(vscode-plugin): Add CMake Support by [@​mcecode](https://github.com/mcecode) in Automattic/harper#360 #### New Contributors - [@​aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347 - [@​hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324 - [@​alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353 **Full Changelog**: Automattic/harper@v0.14.0...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
Add CMake support to the VSCode extension as per #353.
As an aside, I was about to update the changelog but I noticed that it was removed in ace693c with the reasoning that it doesn't get updated. I just wanted to ask, what exactly wasn't being updated? Since, as far as I can recall, it was updated every time the extension was. Did it mean that the
## Unreleased
section wasn't being updated to the correct version every release? If so, that can be remedied by adding a command to also bump it in thejustfile
bump-versions
recipe. I can add that to this PR, if you think it's a good idea.