feat(harper-ls): remove deleted file/s diagnostics #304

mcecode · 2024-12-05T00:10:35Z

I noticed that even after files are deleted, their diagnostics stay. This fixes that.

elijah-potter

I've got a concern or two, but otherwise it looks great! Thanks for noticing the issue.

harper-ls/src/backend.rs

packages/vscode-plugin/src/tests/suite/integration.test.ts

…e_files`

mcecode · 2025-01-08T11:06:22Z

Took me a while to get back to this but I think it's ready. It now also picks up deletions that happen outside of the editor.

elijah-potter requested changes Dec 5, 2024

View reviewed changes

harper-ls/src/backend.rs Outdated Show resolved Hide resolved

packages/vscode-plugin/src/tests/suite/integration.test.ts Show resolved Hide resolved

mcecode marked this pull request as draft December 6, 2024 16:17

mcecode added 4 commits January 8, 2025 11:24

feat(harper-ls): clear diagnostics when file is deleted

63ebbc8

feat(vscode-plugin): add file deletion test

9892ded

feat(harper-ls): use did_change_watched_files instead of `did_delet…

4009440

…e_files`

feat(vscode-plugin): update file deletion test

8d4b0c5

mcecode force-pushed the deleted-file-diagnostics branch from 760e004 to 8d4b0c5 Compare January 8, 2025 10:46

fix(vscode-plugin): increase sleep of failing case

19977c2

mcecode marked this pull request as ready for review January 8, 2025 11:06

elijah-potter merged commit c9d8c2f into Automattic:master Jan 8, 2025
4 checks passed

mcecode deleted the deleted-file-diagnostics branch January 9, 2025 02:14

Provide feedback