Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive for "Subordinating conjunctions should not appear at the end of a clause." #341

Open
jvoisin opened this issue Dec 30, 2024 · 2 comments
Assignees

Comments

@jvoisin
Copy link

jvoisin commented Dec 30, 2024

I'm getting a "Subordinating conjunctions like “only,” should not appear at the end of a clause." diagnostic on the following sentence:

The structure has a couple of fields marked read-only, like A and B

An easy fix would be to check if the conjunction is preceded by a space character.

@elijah-potter
Copy link
Collaborator

Thanks for bringing this up. I've implemented a rough solution to this. It will be out in the next release. Mind if I ping you when that happens so you can confirm that it's working on your end?

@jvoisin
Copy link
Author

jvoisin commented Jan 2, 2025

I'll update the issue once the release is out, and I can confirm that it fixes the issue, no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants