-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): extended
OxfordCommas
to cover *or*
cases
- Loading branch information
1 parent
d516897
commit 29983db
Showing
1 changed file
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29983db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should have been updated to mention the or
29983db#diff-ce301fc752684fe434e0eceeb657696fdc489530108543fe5ee86a16e51adce8L84
BTW, I found no PR for this commit, is it normal?
29983db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to open a PR for this, or would you rather I make the change? If you decide to do the former, you would be able to get a feel for our contribution process 😄. I also want to make sure you get added to the contributors list, even if it is a small change.
Thanks for noticing!
We're only just now starting to strongly incorporate PRs into how we evolve the code. For old commits, it is normal.