Skeleton refactoring #28

massimim · 2022-10-25T13:15:55Z

New skeleton implementation.

Unit test results on Snoopy (DGX A100)

Create new tag: 20221125-2159 - Experimental
Cannot find file: /home/max/repos/Neon/temp/Neon/build/DartConfiguration.tcl
Test project /home/max/repos/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/43 Test  #1: coreUt_chrono .....................   Passed   36.00 sec
      Start  2: coreUt_cli
 2/43 Test  #2: coreUt_cli ........................   Passed    0.00 sec
      Start  3: coreUt_digraph
 3/43 Test  #3: coreUt_digraph ....................   Passed    0.00 sec
      Start  4: coreUt_exceptions
 4/43 Test  #4: coreUt_exceptions .................   Passed    0.00 sec
      Start  5: coreUt_io
 5/43 Test  #5: coreUt_io .........................   Passed    9.52 sec
      Start  6: coreUt_logging
 6/43 Test  #6: coreUt_logging ....................   Passed    0.00 sec
      Start  7: coreUt_tools
 7/43 Test  #7: coreUt_tools ......................   Passed    0.00 sec
      Start  8: coreUt_tuple3d
 8/43 Test  #8: coreUt_tuple3d ....................   Passed    0.00 sec
      Start  9: sysUt_devCpu
 9/43 Test  #9: sysUt_devCpu ......................   Passed    0.96 sec
      Start 10: sysUt_devGpu
10/43 Test #10: sysUt_devGpu ......................   Passed    1.09 sec
      Start 11: sysUt_devGpuNvcc
11/43 Test #11: sysUt_devGpuNvcc ..................   Passed    1.10 sec
      Start 12: sysUt_mem
12/43 Test #12: sysUt_mem .........................   Passed    1.14 sec
      Start 13: sysUt_mem3d
13/43 Test #13: sysUt_mem3d .......................   Passed    1.52 sec
      Start 14: sysUt_patterns
14/43 Test #14: sysUt_patterns ....................   Passed    2.17 sec
      Start 15: sysUt_report
15/43 Test #15: sysUt_report ......................   Passed    1.00 sec
      Start 16: setUt_gpuSet
16/43 Test #16: setUt_gpuSet ......................   Passed    2.18 sec
      Start 17: setUt_gpuSetNvcc
17/43 Test #17: setUt_gpuSetNvcc ..................   Passed    0.90 sec
      Start 18: setUt_memMirrorSet
18/43 Test #18: setUt_memMirrorSet ................   Passed    2.18 sec
      Start 19: setUt_patterns
19/43 Test #19: setUt_patterns ....................   Passed    1.86 sec
      Start 20: setUt_multiDeviceObject
20/43 Test #20: setUt_multiDeviceObject ...........   Passed    1.14 sec
      Start 21: setUt_containerGraph
21/43 Test #21: setUt_containerGraph ..............   Passed    5.38 sec
      Start 22: gUt_containers
22/43 Test #22: gUt_containers ....................   Passed    1.51 sec
      Start 23: gUt_containers
23/43 Test #23: gUt_containers ....................   Passed    1.63 sec
      Start 24: gUt_dataView_patterns
24/43 Test #24: gUt_dataView_patterns .............   Passed  357.79 sec
      Start 25: domain-unit-test-map
25/43 Test #25: domain-unit-test-map ..............   Passed   13.19 sec
      Start 26: domain-unit-test-cast
26/43 Test #26: domain-unit-test-cast .............   Passed   13.03 sec
      Start 27: gUt_patterns_container
27/43 Test #27: gUt_patterns_container ............   Passed  551.06 sec
      Start 28: domainUt_swap
28/43 Test #28: domainUt_swap .....................   Passed   62.10 sec
      Start 29: domain-unit-test-staggered-grid
29/43 Test #29: domain-unit-test-staggered-grid ...   Passed   37.65 sec
      Start 30: gUt_tools
30/43 Test #30: gUt_tools .........................   Passed    1.33 sec
      Start 31: gUt_vtk
31/43 Test #31: gUt_vtk ...........................   Passed    1.80 sec
      Start 32: gUt_bGrid
32/43 Test #32: gUt_bGrid .........................   Passed    1.29 sec
      Start 33: sUt_skeleton
33/43 Test #33: sUt_skeleton ......................   Passed  183.73 sec
      Start 34: sUt_skeletonOnStreams
34/43 Test #34: sUt_skeletonOnStreams .............   Passed  1245.07 sec
      Start 35: sUt_userInterface
35/43 Test #35: sUt_userInterface .................   Passed  141.43 sec
      Start 36: sUt_stencil
36/43 Test #36: sUt_stencil .......................   Passed    3.09 sec
      Start 37: solverUt_Poisson
37/43 Test #37: solverUt_Poisson ..................   Passed    0.89 sec
      Start 38: solverPt_Poisson
38/43 Test #38: solverPt_Poisson ..................   Passed    3.52 sec
      Start 39: tutorial-staggered-grid
39/43 Test #39: tutorial-staggered-grid ...........   Passed    1.28 sec
      Start 40: app-fractal
40/43 Test #40: app-fractal .......................   Passed    1.22 sec
      Start 41: app-lbm
41/43 Test #41: app-lbm ...........................   Passed   18.42 sec
      Start 42: app-gameOfLife
42/43 Test #42: app-gameOfLife ....................   Passed   12.18 sec
      Start 43: app-poisson
43/43 Test #43: app-poisson .......................   Passed    3.95 sec

100% tests passed, 0 tests failed out of 43

Total Test time (real) = 2725.35 sec

…n node.

massimim · 2022-11-25T23:16:00Z

An unit test (domain-unit-test-staggered-grid NodeToVoxels.dGrid) highlighted an issue on a staggered grid test that is not related to the skeleton. The effected unit test has been temporarily disabled.

Domain-unit-test-staggered-grid NodeToVoxels.dGrid is failing on DGX #30

massimim · 2022-11-25T23:20:39Z

bGrid unit tests in sUt_skeletonOnStreams have been temporary disabled until bGrid is extended to multi-GPUs.

Ahdhn

Looking good! I just left a minor comment

Ahdhn · 2022-12-01T21:36:15Z

libNeonCore/include/Neon/core/tools/Logger.h

@@ -53,7 +53,12 @@ LIBNEONCORE_EXPORT extern Logger LoggerObj;

 }  // namespace Neon

+#if defined( NEON_ACTIVETE_TRACING)


I think we don't need this. If you want to turn the logging completely off you can just do Neon::globalSpace::LoggerObj.set_level(spdlog::level::off)

Ahdhn · 2022-12-01T22:33:08Z

There are a couple of failed tests on Windows. Here is the complete report
CTestNeonWindowsReport.log

massimim · 2022-12-05T17:41:41Z

Part of the test that are failing are not related to the skeleton. What window system are you using?

Ahdhn · 2022-12-09T12:11:35Z

Windows logs

Create new tag: 20221209-0432 - Experimental
Cannot find file: E:/Github/Neon/temp/Neon/build/DartConfiguration.tcl
Test project E:/Github/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/43 Test  #1: coreUt_chrono .....................   Passed   36.34 sec
      Start  2: coreUt_cli
 2/43 Test  #2: coreUt_cli ........................   Passed    0.18 sec
      Start  3: coreUt_digraph
 3/43 Test  #3: coreUt_digraph ....................   Passed    0.21 sec
      Start  4: coreUt_exceptions
 4/43 Test  #4: coreUt_exceptions .................   Passed    0.57 sec
      Start  5: coreUt_io
 5/43 Test  #5: coreUt_io .........................   Passed   34.94 sec
      Start  6: coreUt_logging
 6/43 Test  #6: coreUt_logging ....................   Passed    0.23 sec
      Start  7: coreUt_tools
 7/43 Test  #7: coreUt_tools ......................   Passed    0.16 sec
      Start  8: coreUt_tuple3d
 8/43 Test  #8: coreUt_tuple3d ....................   Passed    0.21 sec
      Start  9: sysUt_devCpu
 9/43 Test  #9: sysUt_devCpu ......................   Passed    0.38 sec
      Start 10: sysUt_devGpu
10/43 Test #10: sysUt_devGpu ......................   Passed    0.52 sec
      Start 11: sysUt_devGpuNvcc
11/43 Test #11: sysUt_devGpuNvcc ..................   Passed    0.48 sec
      Start 12: sysUt_mem
12/43 Test #12: sysUt_mem .........................   Passed   10.54 sec
      Start 13: sysUt_mem3d
13/43 Test #13: sysUt_mem3d .......................   Passed    0.75 sec
      Start 14: sysUt_patterns
14/43 Test #14: sysUt_patterns ....................   Passed    2.11 sec
      Start 15: sysUt_report
15/43 Test #15: sysUt_report ......................   Passed    0.29 sec
      Start 16: setUt_gpuSet
16/43 Test #16: setUt_gpuSet ......................   Passed    0.47 sec
      Start 17: setUt_gpuSetNvcc
17/43 Test #17: setUt_gpuSetNvcc ..................   Passed    0.25 sec
      Start 18: setUt_memMirrorSet
18/43 Test #18: setUt_memMirrorSet ................   Passed    0.49 sec
      Start 19: setUt_patterns
19/43 Test #19: setUt_patterns ....................   Passed    1.71 sec
      Start 20: setUt_multiDeviceObject
20/43 Test #20: setUt_multiDeviceObject ...........   Passed    0.52 sec
      Start 21: setUt_containerGraph
21/43 Test #21: setUt_containerGraph ..............   Passed    3.37 sec
      Start 22: gUt_containers
22/43 Test #22: gUt_containers ....................   Passed    0.56 sec
      Start 23: gUt_containers
23/43 Test #23: gUt_containers ....................   Passed    0.34 sec
      Start 24: gUt_dataView_patterns
24/43 Test #24: gUt_dataView_patterns .............   Passed  596.95 sec
      Start 25: domain-unit-test-map
25/43 Test #25: domain-unit-test-map ..............   Passed    3.83 sec
      Start 26: domain-unit-test-cast
26/43 Test #26: domain-unit-test-cast .............   Passed    3.81 sec
      Start 27: gUt_patterns_container
27/43 Test #27: gUt_patterns_container ............   Passed  866.23 sec
      Start 28: domainUt_swap
28/43 Test #28: domainUt_swap .....................   Passed   11.00 sec
      Start 29: domain-unit-test-staggered-grid
29/43 Test #29: domain-unit-test-staggered-grid ...   Passed    0.34 sec
      Start 30: gUt_tools
30/43 Test #30: gUt_tools .........................   Passed    0.37 sec
      Start 31: gUt_vtk
31/43 Test #31: gUt_vtk ...........................   Passed    0.62 sec
      Start 32: gUt_bGrid
32/43 Test #32: gUt_bGrid .........................   Passed    0.49 sec
      Start 33: sUt_skeleton
33/43 Test #33: sUt_skeleton ......................   Passed  132.95 sec
      Start 34: sUt_skeletonOnStreams
34/43 Test #34: sUt_skeletonOnStreams .............   Passed  674.49 sec
      Start 35: sUt_userInterface
35/43 Test #35: sUt_userInterface .................   Passed  186.60 sec
      Start 36: sUt_stencil
36/43 Test #36: sUt_stencil .......................   Passed    1.15 sec
      Start 37: solverUt_Poisson
37/43 Test #37: solverUt_Poisson ..................   Passed    0.64 sec
      Start 38: solverPt_Poisson
38/43 Test #38: solverPt_Poisson ..................   Passed    7.13 sec
      Start 39: tutorial-staggered-grid
39/43 Test #39: tutorial-staggered-grid ...........   Passed    0.38 sec
      Start 40: app-fractal
40/43 Test #40: app-fractal .......................   Passed    0.81 sec
      Start 41: app-lbm
41/43 Test #41: app-lbm ...........................   Passed   33.50 sec
      Start 42: app-gameOfLife
42/43 Test #42: app-gameOfLife ....................   Passed   21.41 sec
      Start 43: app-poisson
43/43 Test #43: app-poisson .......................   Passed    5.29 sec

100% tests passed, 0 tests failed out of 43

Total Test time (real) = 2643.83 sec

massimim added 30 commits July 14, 2022 14:11

DeviceTypeUtil: fixing name in string.

7ee19a1

Adding a mutable version of getBackend in GridBase.

1fe86f4

WIP: New container interface

ef1b18a

Adding some extra information to report for a device report.

a07f632

WIP: New container interface

cc64f77

Documentation

f03bb2e

Merge remote-tracking branch 'origin/develop' into container

f4d851d

Fixing merging issues.

1d06c32

Documentation

090e57f

Imposing coding standards on the Container class.

182155b

WIP: new container graph mechanism.

0a944c3

Merge remote-tracking branch 'origin/develop' into container

b2cefa1

WIP

3c7a25b

WIP

7942c0a

WIP

23b2d34

WIP

87ffb4c

WIP

7d11d4d

WIP

c05341e

WIP

78bb946

WIP

fe27bd2

WIP

f709e8b

WIP

cf2dee4

WIP

0796ddb

WIP

16f4e5d

WIP

1583db7

WIP

bd57943

WIP

b62fb87

WIP

150a045

WIP

601915f

WIP

1a67851

massimim added 10 commits November 8, 2022 12:37

Mechanism to support eGrid in the new skeleton.

2a833b5

Mechanism to support eGrid in the new skeleton.

db8a4fb

Merge remote-tracking branch 'origin/skeleton' into skeleton

78095e2

Cleaning up.

a924689

WIP

5e874af

Adding support for those cases where a stencil nodes follows the begi…

ddaf844

…n node.

Adding support for those cases where a stencil nodes follows the begi…

58cd81c

…n node.

Adding support for those cases where a stencil nodes follows the begi…

4fd3454

…n node.

Fixing compilation issue on Ubuntu.

347d9a3

Fixing compiler issues on Windows

e49b486

massimim requested review from Ahdhn and removed request for Ahdhn November 23, 2022 22:31

massimim added 2 commits November 25, 2022 11:49

WIP

447d784

Increasing domain side for 8-GPU computation.

c5fcc6a

massimim force-pushed the skeleton branch from 0f2534b to c5fcc6a Compare November 25, 2022 20:07

Disabling domain-unit-test-staggered-grid NodeToVoxels.dGrid test.

c85a387

massimim requested a review from Ahdhn November 25, 2022 23:12

massimim marked this pull request as ready for review November 25, 2022 23:20

Ahdhn approved these changes Dec 1, 2022

View reviewed changes

massimim added 2 commits December 8, 2022 14:51

Adding Ahmed's fix for the cmake-openmp issue on windows.

754ced0

Temporarily disabling staggered grid unit tests.

108dd9a

Fixing compiler issue on Windows.

4c9fc6b

massimim merged commit 7a180a4 into develop Dec 9, 2022

massimim deleted the skeleton branch December 9, 2022 15:24

github-actions bot locked and limited conversation to collaborators Dec 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skeleton refactoring #28

Skeleton refactoring #28

massimim commented Oct 25, 2022 •

edited

Loading

massimim commented Nov 25, 2022 •

edited

Loading

massimim commented Nov 25, 2022

Ahdhn left a comment

Ahdhn Dec 1, 2022

Ahdhn commented Dec 1, 2022

massimim commented Dec 5, 2022

Ahdhn commented Dec 9, 2022

		@@ -53,7 +53,12 @@ LIBNEONCORE_EXPORT extern Logger LoggerObj;

		} // namespace Neon

		#if defined( NEON_ACTIVETE_TRACING)

Skeleton refactoring #28

Skeleton refactoring #28

Conversation

massimim commented Oct 25, 2022 • edited Loading

massimim commented Nov 25, 2022 • edited Loading

massimim commented Nov 25, 2022

Ahdhn left a comment

Choose a reason for hiding this comment

Ahdhn Dec 1, 2022

Choose a reason for hiding this comment

Ahdhn commented Dec 1, 2022

massimim commented Dec 5, 2022

Ahdhn commented Dec 9, 2022

massimim commented Oct 25, 2022 •

edited

Loading

massimim commented Nov 25, 2022 •

edited

Loading