Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar testing #64

Merged
merged 8 commits into from
Jul 26, 2020
Merged

Nav bar testing #64

merged 8 commits into from
Jul 26, 2020

Conversation

allyjarjour
Copy link
Collaborator

@allyjarjour allyjarjour commented Jul 26, 2020

Type of change:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Styling - no new features
  • Testing

Why is this change required? What problem(s) does it solve?

Adds a unit test for the NavBar

Were there any challenges while implementing this feature? If so, how were they addressed?

We may want to update this once we start using the react-native-testing-library. Also , I wasn't able to rebase this branch because it kept overwriting my updates even though I pulled in changes from the origin master.

Where should the reviewer start? How can this be tested?

NavBar folder

Link issues

#49 in progress

@broxbury broxbury merged commit 523e353 into master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants