Skip to content

Commit

Permalink
LibWeb: Bring HTMLHyperlinkElementUtils::hostname() closer to spec
Browse files Browse the repository at this point in the history
Actually reinitialize the URL like we are supposed to, and then check if
it's null. Also add some missing spec links.
  • Loading branch information
AtkinsSJ committed Nov 28, 2024
1 parent f8187c6 commit c15aedb
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,22 +198,24 @@ void HTMLHyperlinkElementUtils::set_host(StringView host)
update_href();
}

// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-hostname
String HTMLHyperlinkElementUtils::hostname() const
{
// 1. Reinitialize url.
//
reinitialize_url();

// 2. Let url be this element's url.
URL::URL url(href());
auto url = m_url;

// 3. If url or url's host is null, return the empty string.
// FIXME: How can url be null here?
if (!url.host().has_value())
if (!url.has_value() || !url->host().has_value())
return String {};

// 4. Return url's host, serialized.
return url.serialized_host();
return url->serialized_host();
}

// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-hostname
void HTMLHyperlinkElementUtils::set_hostname(StringView hostname)
{
// 1. Reinitialize url.
Expand Down

0 comments on commit c15aedb

Please sign in to comment.