fix: select character arrow visibility #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodicolo
requested changes
Feb 22, 2025
Comment on lines
176
to
183
|
|
||
| // in case the json load is changing the visibility of the arrows when it shouldn't | ||
| // lets ensure the right value | ||
| if (CharacterSelectionPreviews != default) | ||
| { | ||
| _selectCharacterRightButton.IsHidden = CharacterSelectionPreviews.Length <= 1; | ||
| _selectCharacterLeftButton.IsHidden = CharacterSelectionPreviews.Length <= 1; | ||
| } |
There was a problem hiding this comment.
Move this all to Show() instead, otherwise they will display wrong if someone logs in, the server closes, the configuration is changed, and then they re-log in
WeylonSantana
force-pushed
the
fix-2604
branch
from
ab7b32d to
2964c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2604
UpdateDisplay() is called before EnsureEnsureInitialized()
Update display hides the arrows, when the condition is true, EnsureEnsureInitialized loads the json value which is false, so the arrows appear when they shouldn't