Added question service and linked it with the gateway service #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I should also add I installed version 8 of wikibase-sdk because it is the last version supporting 'require', but it should not cause any problems still and functionally it is practically the same. This is the documentation page for this version: https://github.com/maxlath/wikibase-sdk/tree/v8.1.1#as-a-module |
|
Seems as a pretty good microservice Christian. The library shouldn't be a problem, we'll write it down in the documentation! The rest looks just fine. And for the moment let's not worry about the tests as they were not programmed for our new API ;) |
|
Quieres que borre la rama? @ChristianFN2 |
andrrsin
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question service should be prepared for use.
Please, check if the linking in the gateway service is correct.
Also, if you are in charge of using the question service, check the documentation of the endpoints to know the format the responses are sent with and the required format when sending the requests (We can discuss if you find another format more appropriate/comfortable).