Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): record model name for llm spans in playground #5001

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

axiomofjoy
Copy link
Contributor

Records model name for LLM spans created in playground.

resolves #4995

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 14, 2024
@axiomofjoy axiomofjoy changed the base branch from main to playground October 14, 2024 22:12
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 14, 2024
@axiomofjoy axiomofjoy force-pushed the xander/record-model-name branch from 95e7138 to 0a31041 Compare October 14, 2024 22:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
@axiomofjoy axiomofjoy changed the base branch from playground to xander/playground-model-name October 14, 2024 22:19
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@mikeldking
Copy link
Contributor

base branch is strange?

Base automatically changed from xander/playground-model-name to playground October 15, 2024 00:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 15, 2024
@axiomofjoy
Copy link
Contributor Author

base branch is strange?

stacked prs

@axiomofjoy axiomofjoy force-pushed the xander/record-model-name branch from 0a31041 to 3796b51 Compare October 15, 2024 00:08
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 15, 2024
@axiomofjoy axiomofjoy merged commit 716b1c7 into playground Oct 15, 2024
26 checks passed
@axiomofjoy axiomofjoy deleted the xander/record-model-name branch October 15, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[playground] record llm.model_name
2 participants