feat(auth): add returnUrl for users that try to access a page while logged out #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
Parker-Stafford
commented
Sep 13, 2024
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| /* Language and Environment */ | |||
| "target": "ES2020" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */, | |||
| // "lib": [], /* Specify a set of bundled library declaration files that describe the target runtime environment. */ | |||
| "lib": ["ES2020", "DOM"], /* Specify a set of bundled library declaration files that describe the target runtime environment. */ | |||
There was a problem hiding this comment.
es2020 allows for access to string.startsWith, dom needed for dom things
RogerHYang
approved these changes
Sep 13, 2024
RogerHYang
pushed a commit
that referenced
this pull request
Sep 21, 2024
…ogged out (#4610) * feat(auth): add returnUrl for users that try to access a page while logged out * tests and fixes
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4605
basic login:
Screen.Recording.2024-09-13.at.12.41.23.AM.mov
new user password reset
Screen.Recording.2024-09-13.at.1.07.31.AM.mov