From a40416129cad21cd8c01cda9e8446a8c5b450ffa Mon Sep 17 00:00:00 2001 From: Roger Yang Date: Fri, 4 Oct 2024 20:38:39 -0700 Subject: [PATCH] feat: make serve command optional --- app/tests/utils/testServer.mjs | 2 +- src/phoenix/server/main.py | 2 +- tests/integration/_helpers.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/tests/utils/testServer.mjs b/app/tests/utils/testServer.mjs index ff0daf099c..43e59f8edf 100644 --- a/app/tests/utils/testServer.mjs +++ b/app/tests/utils/testServer.mjs @@ -21,7 +21,7 @@ console.log("PHOENIX_WORKING_DIR: ", process.env["PHOENIX_WORKING_DIR"]); // Execute the server // TODO: Might have to force install the phoenix server -const childProcess = exec("python -m phoenix.server.main serve"); +const childProcess = exec("python -m phoenix.server.main"); childProcess.stdout.pipe(process.stdout); childProcess.stderr.pipe(process.stderr); diff --git a/src/phoenix/server/main.py b/src/phoenix/server/main.py index 82449539f2..8318be0469 100644 --- a/src/phoenix/server/main.py +++ b/src/phoenix/server/main.py @@ -237,7 +237,7 @@ def main() -> None: ) demo_parser.add_argument("--simulate-streaming", action="store_true") - args = parser.parse_args() + args = parser.parse_args(sys.argv[1:] or ["serve"]) db_connection_str = ( args.database_url if args.database_url else get_env_database_connection_str() ) diff --git a/tests/integration/_helpers.py b/tests/integration/_helpers.py index b4ad8364d7..09ff9157a1 100644 --- a/tests/integration/_helpers.py +++ b/tests/integration/_helpers.py @@ -601,7 +601,7 @@ def _server() -> Iterator[None]: if get_env_database_connection_str().startswith("postgresql"): # double-check for safety assert get_env_database_schema() - command = f"{sys.executable} -m phoenix.server.main serve" + command = f"{sys.executable} -m phoenix.server.main" process = Popen(command.split(), stdout=PIPE, stderr=STDOUT, text=True, env=os.environ) log: List[str] = [] lock: Lock = Lock()