From 13886d42c7f4fa475859f8e72e015e5b7948de32 Mon Sep 17 00:00:00 2001
From: Archomeda <archomeda@hotmail.com>
Date: Sat, 11 Mar 2023 19:36:40 +0100
Subject: [PATCH 1/2] Rework RequestException temporarily as a less breaking
 change compared to 2.0

---
 .../WebApi/Exceptions/RequestException.cs     | 57 ++++++++++++-------
 1 file changed, 35 insertions(+), 22 deletions(-)

diff --git a/Gw2Sharp/WebApi/Exceptions/RequestException.cs b/Gw2Sharp/WebApi/Exceptions/RequestException.cs
index a8b42c6ef..fcfc0558f 100644
--- a/Gw2Sharp/WebApi/Exceptions/RequestException.cs
+++ b/Gw2Sharp/WebApi/Exceptions/RequestException.cs
@@ -6,16 +6,17 @@ namespace Gw2Sharp.WebApi.Exceptions
     /// <summary>
     /// A generic request exception used for the web API.
     /// </summary>
-    public class RequestException : RequestException<string>
+    public class RequestException : Exception
     {
         /// <summary>
         /// Creates a new <see cref="RequestException" />.
         /// </summary>
         /// <param name="request">The original request.</param>
         /// <param name="message">The message.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
         public RequestException(IWebApiRequest request, string message) :
-            base(request, message) { }
+            this(request, null, message, null)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException" />.
@@ -23,9 +24,10 @@ public RequestException(IWebApiRequest request, string message) :
         /// <param name="request">The original request.</param>
         /// <param name="response">The response.</param>
         /// <param name="message">The message.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
         public RequestException(IWebApiRequest request, IWebApiResponse<string>? response, string message) :
-            base(request, response, message) { }
+            this(request, response, message, null)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException" />.
@@ -33,9 +35,10 @@ public RequestException(IWebApiRequest request, IWebApiResponse<string>? respons
         /// <param name="request">The original request.</param>
         /// <param name="message">The message.</param>
         /// <param name="innerException">The inner exception.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
         public RequestException(IWebApiRequest request, string message, Exception? innerException) :
-            base(request, message, innerException) { }
+            this(request, null, message, innerException)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException" />.
@@ -44,9 +47,22 @@ public RequestException(IWebApiRequest request, string message, Exception? inner
         /// <param name="response">The response.</param>
         /// <param name="message">The message.</param>
         /// <param name="innerException">The inner exception.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
-        public RequestException(IWebApiRequest request, IWebApiResponse<string>? response, string message, Exception innerException) :
-            base(request, response, message, innerException) { }
+        public RequestException(IWebApiRequest request, IWebApiResponse<string>? response, string message, Exception? innerException) :
+            base(message, innerException)
+        {
+            this.Request = request ?? throw new ArgumentNullException(nameof(request));
+            this.Response = response;
+        }
+
+        /// <summary>
+        /// Gets the original request.
+        /// </summary>
+        public IWebApiRequest Request { get; }
+
+        /// <summary>
+        /// Gets the response.
+        /// </summary>
+        public IWebApiResponse<string>? Response { get; }
     }
 
 
@@ -54,7 +70,7 @@ public RequestException(IWebApiRequest request, IWebApiResponse<string>? respons
     /// A generic request exception used for the web API.
     /// </summary>
     /// <typeparam name="TResponse">The response object.</typeparam>
-    public class RequestException<TResponse> : Exception
+    public class RequestException<TResponse> : RequestException
     {
         /// <summary>
         /// Creates a new <see cref="RequestException{TResponse}" />.
@@ -63,7 +79,8 @@ public class RequestException<TResponse> : Exception
         /// <param name="message">The message.</param>
         /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, string message) :
-            this(request, null, message, null) { }
+            this(request, null, message, null)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException{TResponse}" />.
@@ -73,7 +90,8 @@ public RequestException(IWebApiRequest request, string message) :
         /// <param name="message">The message.</param>
         /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, IWebApiResponse<TResponse>? response, string message) :
-            this(request, response, message, null) { }
+            this(request, response, message, null)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException{TResponse}" />.
@@ -83,7 +101,8 @@ public RequestException(IWebApiRequest request, IWebApiResponse<TResponse>? resp
         /// <param name="innerException">The inner exception.</param>
         /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, string message, Exception? innerException) :
-            this(request, null, message, innerException) { }
+            this(request, null, message, innerException)
+        { }
 
         /// <summary>
         /// Creates a new <see cref="RequestException{TResponse}" />.
@@ -93,20 +112,14 @@ public RequestException(IWebApiRequest request, string message, Exception? inner
         /// <param name="message">The message.</param>
         /// <param name="innerException">The inner exception.</param>
         public RequestException(IWebApiRequest request, IWebApiResponse<TResponse>? response, string message, Exception? innerException) :
-            base(message, innerException)
+            base(request, null, message, innerException)
         {
-            this.Request = request ?? throw new ArgumentNullException(nameof(request));
             this.Response = response;
         }
 
-        /// <summary>
-        /// Gets the original request.
-        /// </summary>
-        public IWebApiRequest Request { get; }
-
         /// <summary>
         /// Gets the response.
         /// </summary>
-        public IWebApiResponse<TResponse>? Response { get; }
+        public new IWebApiResponse<TResponse>? Response { get; }
     }
 }

From 30d3f2dbd11e497ae75809505bbacd2ef8bb4aeb Mon Sep 17 00:00:00 2001
From: Archomeda <archomeda@hotmail.com>
Date: Sat, 11 Mar 2023 19:42:47 +0100
Subject: [PATCH 2/2] Use see langword

---
 Gw2Sharp/WebApi/Exceptions/RequestException.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Gw2Sharp/WebApi/Exceptions/RequestException.cs b/Gw2Sharp/WebApi/Exceptions/RequestException.cs
index fcfc0558f..7e994ffc5 100644
--- a/Gw2Sharp/WebApi/Exceptions/RequestException.cs
+++ b/Gw2Sharp/WebApi/Exceptions/RequestException.cs
@@ -13,7 +13,7 @@ public class RequestException : Exception
         /// </summary>
         /// <param name="request">The original request.</param>
         /// <param name="message">The message.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, string message) :
             this(request, null, message, null)
         { }
@@ -24,7 +24,7 @@ public RequestException(IWebApiRequest request, string message) :
         /// <param name="request">The original request.</param>
         /// <param name="response">The response.</param>
         /// <param name="message">The message.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, IWebApiResponse<string>? response, string message) :
             this(request, response, message, null)
         { }
@@ -35,7 +35,7 @@ public RequestException(IWebApiRequest request, IWebApiResponse<string>? respons
         /// <param name="request">The original request.</param>
         /// <param name="message">The message.</param>
         /// <param name="innerException">The inner exception.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <c>null</c>.</exception>
+        /// <exception cref="ArgumentNullException"><paramref name="request"/> or <paramref name="message"/> is <see langword="null"/>.</exception>
         public RequestException(IWebApiRequest request, string message, Exception? innerException) :
             this(request, null, message, innerException)
         { }