Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding danish localization support #1072

Open
wants to merge 2 commits into
base: 10.10
Choose a base branch
from

Conversation

Mats-Jakobsson
Copy link

No description provided.

@Mats-Jakobsson
Copy link
Author

@ZhijieZhang - I saw that you have approved previous PR:s, could we get a couple of eyes on this? Thanks. If not you, do you know who to contact to get danish in? Thanks in advance.

@NoftScarlet
Copy link
Contributor

Thank you for the pull request, @Mats-Jakobsson ! Looks like trivial a change to the code but nice to have.
Hey @mparizeau-pdftron and @bollain would you mind taking a look at the PR? Thanks!

@bollain bollain self-assigned this Nov 28, 2024
@bollain
Copy link
Collaborator

bollain commented Nov 28, 2024

hi @Mats-Jakobsson, thanks for making this PR!

I have merged this internally in the WebViewer solution, and it will be available in the nightly 11.1 release starting tomorrow.

Are you currently building the UI from this repo or downloading it via NPM?

@bollain
Copy link
Collaborator

bollain commented Nov 28, 2024

@Mats-Jakobsson - looking further into this, the PR introduces a number of keys that are not present in other languages. Are these specific to your fork of WebViewer UI? If this is the case, we cannot merge them to our dev branches as they are specific to your fork. However, we can add Danish as an option and include translations for all the default keys used in WebViewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants