-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for adding custom modals or popups #34
Comments
Yup, we also think that similar API should exist for modals and popups. It's in our roadmap, but not the highest priority at the moment. Hopefully we will get to it soon and create better dev experience for everyone :) |
Something else I would like to add is that you might want to think about how you want to handle the onkey listeners for when a modal is open. In our product, we had a modal specifically linked to the selected annotation, and pressing delete would cause the annotation to be deleted and thus the modal to close. Because ondelete seemed to be handled in core code, I had to set up my own listener that would stop propagation if my modal was open. Perhaps you could turn off all listeners if a modal is open? (This comment is related to issue #41)
|
That's a great point. We'll consider it when we design the API. |
This would be very useful for our use as well for page operations. For moving and adding pages we pop up separate modals right now but it is a bit clunky and doesn't work when using WebViewer in full screen mode. |
During this time we've added a few APIs that can be used to customize modals and popups:
Let us know if you have any other questions. |
Thanks for the new APIs, the ones for custom modals are great to use. |
@ZhijieZhang @justinjung04 any news on this? |
Is there any news on the Custom Popup API front? |
Hi @sabieber, We are currently working on a new and improved way to customize the UI without having to fork this repo, and can explore this requirement more in depth. If I understand correctly you want:
Can you elaborate more on what your ideal use case is, and what an ideal API would look like for you? |
Hi @bollain, thanks for the update and heads up! This sounds really promising. Yes our use case is to create an annotation for the word the user clicked on and displaying a custom popup next to the created annotation. Best would be an API where a popup with a fully custom content (like the dialog APIs) can be created. Also it would be helpful if there was an easy way to update the position of that popup to be next to a specified annotation. |
Hi guys... Can you give me, please, some hints on how this customization works? Any help will be very much appreciated...It's a real struggle just to build it... Even following those steps found in here ((https://docs.apryse.com/documentation/web/guides/advanced-customization/)) I'm using the 10.6 branch. I only get to do those steps after install Visual Studio 2019 with "Desktop development with C++" package... But, after the build, the copied files (from webviewer-ui/build folder) don't work correctly with my app (build with React). :( Someone can help? Tnx in advance!!! |
I really like the new API for adding custom panels to the left panel.
Could you add something similar for modals and popups so APIs like
closeElement
andopenElement
can be accessed there too?The text was updated successfully, but these errors were encountered: