chore: restrict uploadable image types (#7269)

* chore: restrict image format * chore: code cleanup
AppFlowy-IO · Jan 23, 2025 · a79f825 · a79f825
1 parent 862e562
commit a79f825
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/...tend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart b/...tend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart
@@ -165,13 +165,14 @@ class CopyButton extends StatelessWidget {
           size: const Size.square(16),
         ),
         onPressed: () async {
+          final messageText = textMessage.text.trim();
           final document = customMarkdownToDocument(
-            textMessage.text,
+            messageText,
             tableWidth: 250.0,
           );
           await getIt<ClipboardService>().setData(
             ClipboardServiceData(
-              plainText: _getTrimmedPlainText(textMessage.text),
+              plainText: _stripMarkdownIfNecessary(messageText),
               inAppJson: jsonEncode(document.toJson()),
             ),
           );
@@ -186,9 +187,10 @@ class CopyButton extends StatelessWidget {
     );
   }
 
-  String _getTrimmedPlainText(String plainText) {
+  String _stripMarkdownIfNecessary(String plainText) {
     // match and capture inner url as group
     final matches = singleLineMarkdownImageRegex.allMatches(plainText);
+
     if (matches.length != 1) {
       return plainText;
     }

diff --git a/...lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart b/...lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart
@@ -8,6 +8,7 @@ import 'package:appflowy/plugins/document/presentation/editor_plugins/copy_and_p
 import 'package:appflowy/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_plain_text.dart';
 import 'package:appflowy/shared/clipboard_state.dart';
 import 'package:appflowy/startup/startup.dart';
+import 'package:appflowy/util/default_extensions.dart';
 import 'package:appflowy_backend/log.dart';
 import 'package:appflowy_editor/appflowy_editor.dart';
 import 'package:appflowy_editor_plugins/appflowy_editor_plugins.dart';
@@ -247,7 +248,8 @@ Future<bool> _isImageUrl(String text) async {
   if (response.statusCode == 200) {
     final contentType = response.headers['content-type'];
     if (contentType != null) {
-      return contentType.startsWith('image/');
+      return contentType.startsWith('image/') &&
+          defaultImageExtensions.any(contentType.contains);
     }
   }
 

diff --git a/frontend/appflowy_flutter/lib/util/default_extensions.dart b/frontend/appflowy_flutter/lib/util/default_extensions.dart
@@ -13,13 +13,3 @@ const List<String> defaultImageExtensions = [
   'webp',
   'bmp',
 ];
-
-extension ImageStringExtension on String {
-  bool isImageUrl() {
-    final imagePattern = RegExp(
-      r'\.(jpe?g|png|gif|webp|bmp)$',
-      caseSensitive: false,
-    );
-    return imagePattern.hasMatch(this);
-  }
-}