-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cluster credentials to fit new schema #181
Conversation
currently working on this issue:
Error message
|
@@ -268,9 +268,8 @@ def health(self) -> ClusterHealth: | |||
def registry_credentials(self) -> dict[str, RegistryCredentials]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to change this interface because it doesn't match this anymore
…hen you create it the UUID is not generated
@@ -788,8 +788,8 @@ def registry(): | |||
@cluster_client | |||
def credentials_list(cluster: "ClusterClient"): | |||
"""List container registry credentials""" | |||
|
|||
if creds := list(cluster.registry_credentials): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this tab may cause issues
registry creds work now |
What I did
Fixing the cluster registry credentials to connect with the cluster.
fixes: #
How I did it
How to verify it
Checklist