fix: unnecessarily was using explorer when providing proxy info manually #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Feb 19, 2025
src/ape/managers/_contractscache.py
Outdated
|
|
||
| if proxy_info: | ||
| # Contract is a proxy (either was detected or provided). | ||
| if impl_contract := self._get_proxy_contract_type( |
There was a problem hiding this comment.
This can be one of 4 things:
- combined proxy + impl abi
- impl-only abi (for things like simple forwarder proxies)
- proxy-only abi (for things like upgradable proxies that don't have impls, or unverified impl)
- undeterminable contract_type (eitehr impl or proxy)
I think should add a note about this, and consider calling this variable like proxy_contract_type instead (maybe?)
antazoey
commented
Feb 20, 2025
antazoey
force-pushed
the
fix/explorer-unnecessary
branch
from
ed1b0f6 to
cc9e37e
Compare
antazoey
force-pushed
the
fix/explorer-unnecessary
branch
from
7f018c0 to
73f8260
Compare
fubuloubu
previously approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It seems to unnecessarily use the explorer when you provider the proxy manually and the contract type is already cached.
How I did it
How to verify it
Checklist