perf: break early on proxy detection when realize can't get storage #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
antazoey
commented
Feb 18, 2025
| networks.active_provider = init_provider | ||
|
|
||
| assert actual is None # Because of provider. | ||
| assert my_provider.times_get_storage_was_called == 1 |
There was a problem hiding this comment.
This is 4 on the main branch, so this test would fail without the fix
antazoey
commented
Feb 18, 2025
| call `get_storage()` more than once. | ||
| """ | ||
|
|
||
| class MyProvider(LocalProvider): |
There was a problem hiding this comment.
I had to make a new provider because EthTester supports getting storage now, which is a good thing
3 tasks
antazoey
force-pushed
the
perf/avoid-checking-many-proxies-on-not-impl-error
branch
from
24980c6 to
41572a6
Compare
antazoey
force-pushed
the
perf/avoid-checking-many-proxies-on-not-impl-error
branch
from
41572a6 to
5648920
Compare
fubuloubu
approved these changes
Feb 18, 2025
antazoey
deleted the
perf/avoid-checking-many-proxies-on-not-impl-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It breaks early instead of continues when it realized getting storage is not implemented by the provider.
I think all providers these days implement this RPC but if you find yourself in this situation, this would save you a few failing requests.
How I did it
How to verify it
Checklist