Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use our ApeWorX action in tests #2513

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

antazoey
Copy link
Member

What I did

This helps us so much. Benefits:

  • We are always ensuring our github action works (testing goes both ways)
  • We can now use actual compilers in Ape's test, get to delete a lot of annoying test artifacts, hence the high deleted lines of code in this PR
  • Can use dependencies easier, since those get cached now.
  • Allows us to more easily migrate the tests from ape-titanoboa to core, something im working on

How I did it

How to verify it

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

fubuloubu
fubuloubu previously approved these changes Feb 17, 2025
@@ -1021,6 +1023,18 @@ def remove(self, package_id: str, version: str):
manifest_file = self.get_manifest_path(package_id, version)
manifest_file.unlink(missing_ok=True)

@contextmanager
def isolate_cache_changes(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants