fix: default call transactions would not get prepared when sender is a contract #2508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
it is difficult to test this without a provider that can handle impersonated accounts (can't wait for boa to be part of ape core).
but if your account is a contract and you call a fallback method on another contract, the transaction would never get prepared causing you to have to manually specify
nonce=
and everything else you neeed.How I did it
prepare_transaction()
toBaseAddress
class.prepare_transaction()
part.How to verify it
I had to add exception kwarg to
SignatureError
so i can at least verify the txn data is now populated.I also confirmed with breakpoint and it unblocks me someplace else too. added a test.
Checklist