Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify the if statement #14

Merged
merged 1 commit into from
Jan 11, 2025
+3 −12
Merged

refactor: simplify the if statement #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
refactor: simplify the if statement 
The highlighted `if` block can be refactored into a simplified statement, increasing its readability.
@deepsource-autofix
deepsource-autofix[bot] authored Jan 11, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit a27153ba56fb2f859a6a91e0fd560eb0f12b4fd0
5 changes: 1 addition & 4 deletions Cogs/pokemon.py
View file
Original file line number Diff line number Diff line change
@@ -1454,10 +1454,7 @@ def determine_pokemon_category(data_species):


if gender != None:
if gender != "♀️ Female only" or "♂️ Male only" or "Genderless":
gender_differ = True
else:
gender_differ = False
gender_differ = bool(gender != "♀️ Female only" or "♂️ Male only" or "Genderless")
else:
gender_differ = False

5 changes: 1 addition & 4 deletions storage/pokemon.py
View file
Original file line number Diff line number Diff line change
@@ -1064,10 +1064,7 @@ def determine_pokemon_category(data_species):


if gender != None:
if gender != "♀️ Female only" or "♂️ Male only" or "Genderless":
gender_differ = True
else:
gender_differ = False
gender_differ = bool(gender != "♀️ Female only" or "♂️ Male only" or "Genderless")
else:
gender_differ = False

5 changes: 1 addition & 4 deletions storage/predict.py
View file
Original file line number Diff line number Diff line change
@@ -1249,10 +1249,7 @@ def determine_pokemon_category(data_species):


if gender != None:
if gender != "♀️ Female only" or "♂️ Male only" or "Genderless":
gender_differ = True
else:
gender_differ = False
gender_differ = bool(gender != "♀️ Female only" or "♂️ Male only" or "Genderless")
else:
gender_differ = False