Improve vcpkg configuration #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomnes
reviewed
Feb 11, 2025
There was a problem hiding this comment.
If we're going to use an external registry, I think it would be nice to keep a trace of the versions of each dependency.
Supposing https://github.com/AntaresSimulatorTeam/antares-vcpkg-registry was deleted, there would be no way to determine what version of e.g sirius-solver was used for e.g Antares Simulator 9.2.0
src/vcpkg-configuration.json
Outdated
Comment on lines
18
to
21
| "repository": "https://github.com/AntaresSimulatorTeam/antares-vcpkg-registry", | ||
| "baseline": "3fa279503f88d764778bcaacdacd3aa27e323025", | ||
| "packages": [ | ||
| "sirius-solver" |
There was a problem hiding this comment.
Please use antares-integration-v1.7 (currently v1.5) on that registry
There was a problem hiding this comment.
I've updated the registry with sirius 1.7
|
flomnes
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use prescribed configuration with two files, one for application (vcpkg.json) one for configuration (vcpkg-configuration.json).
Use sirius in Antares registry instead of local port.