Toggle billboard on keypress #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the behavior of the vanilla quest journal by toggling (not only opening) the calendar/quest board on [bound] keypress.
taylorjwalker
commented
Apr 26, 2024
UIInfoSuite2/ModEntry.cs
Outdated
| else if (Game1.activeClickableMenu is Billboard billboard) | ||
| { | ||
| Game1.player.FarmerSprite.SetOwner(Game1.player); | ||
| bool isDailyQuestBoard = (bool)(typeof(Billboard).GetField("dailyQuestBoard", BindingFlags.NonPublic | BindingFlags.Instance)?.GetValue(billboard) ?? false); |
There was a problem hiding this comment.
I assume using reflection is not optimal, but I wasn't sure how else to accomplish this. Please feel free to improve.
Also remove call to Game1.player.FarmerSprite.SetOwner. I made these changes a while ago and I'm not sure why that was there.
taylorjwalker
commented
Apr 26, 2024
| { | ||
| helper.Input.SuppressActiveKeybinds(_modConfig.OpenQuestBoardKeybind); | ||
| Game1.RefreshQuestOfTheDay(); |
There was a problem hiding this comment.
I don't think this is necessary since the daily quest is refreshed every morning. Please let me know if I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the behavior of the vanilla quest journal by toggling (not only opening) the calendar/quest board on [bound] keypress.