You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tying any mob with a Lead to a "The Betweenlands" Fence block will pop off after a few seconds.
Looking at the code for Fence block it seems you guys don't extend the vanilla classes and just copies from it instead. The comment at the top of the class mentions it's not "extensible", but looking at other project's code they do that just fine. Forestry for example extends the vanilla BlockFence class.
Addendum
Looks like you guys have copied the source code rather than extend from vanilla in a few other classes. BlockSlabBetweenlands and BlockFenceGateBetweenlands for example. Extending the vanilla classes when possible would probably simplify the code a bit and give better interactions with mods and vanilla.
Expected result:
Not breaking.
Actual result:
Breaking.
The text was updated successfully, but these errors were encountered:
Versions
Betweenlands version:
3.9.5
Forge version:
14.23.5.2860
Singleplayer or Multiplayer:
Both.
Installed mods:
The Betweenlands
Description of the problem
How to reproduce:
Tying any mob with a Lead to a "The Betweenlands" Fence block will pop off after a few seconds.
Looking at the code for Fence block it seems you guys don't extend the vanilla classes and just copies from it instead. The comment at the top of the class mentions it's not "extensible", but looking at other project's code they do that just fine. Forestry for example extends the vanilla
BlockFence
class.Addendum
Looks like you guys have copied the source code rather than extend from vanilla in a few other classes.
BlockSlabBetweenlands
andBlockFenceGateBetweenlands
for example. Extending the vanilla classes when possible would probably simplify the code a bit and give better interactions with mods and vanilla.Expected result:
Not breaking.
Actual result:
Breaking.
The text was updated successfully, but these errors were encountered: