Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Leads breaks if tying a mob to a TB Fence #1368

Open
Shazuli opened this issue Mar 29, 2023 · 0 comments
Open

[BUG] Leads breaks if tying a mob to a TB Fence #1368

Shazuli opened this issue Mar 29, 2023 · 0 comments

Comments

@Shazuli
Copy link

Shazuli commented Mar 29, 2023

Versions

Betweenlands version:

3.9.5

Forge version:

14.23.5.2860

Singleplayer or Multiplayer:

Both.

Installed mods:

The Betweenlands

Description of the problem

How to reproduce:

Tying any mob with a Lead to a "The Betweenlands" Fence block will pop off after a few seconds.

Looking at the code for Fence block it seems you guys don't extend the vanilla classes and just copies from it instead. The comment at the top of the class mentions it's not "extensible", but looking at other project's code they do that just fine. Forestry for example extends the vanilla BlockFence class.

Addendum

Looks like you guys have copied the source code rather than extend from vanilla in a few other classes. BlockSlabBetweenlands and BlockFenceGateBetweenlands for example. Extending the vanilla classes when possible would probably simplify the code a bit and give better interactions with mods and vanilla.

Expected result:

Not breaking.

Actual result:

Breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant