Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): rollback SDWebImage to 5.8.2 to fix threading issues #94

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Cartfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "SDWebImage/SDWebImage" ~> 5.8.4
github "SDWebImage/SDWebImage" == 5.8.2
2 changes: 1 addition & 1 deletion ios/Classes/AvImageviewImageView.m
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ - (void)displayImage:(id)imageObj {
//fix downloading the image if url contains spaces or none ASCII characters
//source : https://stackoverflow.com/questions/1441106/nsdata-nsurl-url-with-space-having-problem
NSString *srtImageUrl = [TiUtils stringValue:imageObj];
srtImageUrl = [srtImageUrl stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]];
srtImageUrl = [srtImageUrl stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];

NSURL *imageUrl = [NSURL URLWithString:srtImageUrl];

Expand Down
2 changes: 1 addition & 1 deletion ios/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 2.1.0
version: 2.1.1
apiversion: 2
architectures: armv7 arm64 i386 x86_64
description: andreavitale-imageview
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
/**
Encode the current image to the data, the image format is unspecified

@note If the receiver is `SDAnimatedImage`, this will return the animated image data if available. No more extra encoding process.
@return The encoded data. If can't encode, return nil
*/
- (nullable NSData *)sd_imageData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ typedef void(^SDSetImageBlock)(UIImage * _Nullable image, NSData * _Nullable ima
/**
* Get the current image operation key. Operation key is used to identify the different queries for one view instance (like UIButton).
* See more about this in `SDWebImageContextSetImageOperationKey`.
* If you cancel current image load, the key will be set to nil.
* @note You can use method `UIView+WebCacheOperation` to investigate different queries' operation.
*/
@property (nonatomic, strong, readonly, nullable) NSString *sd_latestOperationKey;
Expand Down
Binary file modified ios/platform/SDWebImage.framework/Info.plist
Binary file not shown.
Binary file modified ios/platform/SDWebImage.framework/SDWebImage
Binary file not shown.