ESLint 9

[lishaduck]

Last one 😅
Is there a particular reason/dependency holding Sheriff back from ESLint 9 compatibility?
What needs to be done to migrate?

[AndreaPontrandolfo]

I would love to migrate Sheriff to V9.
I'm still exploring here, but it seems like a daunting task.
Most of the ecosystem is still on V8, with some big maintainers saying that the migration will take them months, if not years.
ESLint made a lot of API breaking changes with V9.
I think a lot plugins would break, but i didn't even try.

I think a quick thing we could try is:

• migrate typescript-eslint to latest, because the latest version is V9-ready
• migrate eslint-plugin-unicorn to latest, because the latest version is V9-ready
• wrap most (if not all) plugins that we are using with compat
• hope for the best lol

[lishaduck]

I think I'm write up a gist for this.

I began, but then discovered eslint/eslint#18093 & eslint/eslint#18391.

[AndreaPontrandolfo]

Do you see an issue in particular?

[lishaduck]

I think import & import-x support is blocking. Otherwise, no.
Oh, maybe prettier?

[AndreaPontrandolfo]

I think that import-x is already compatible with V9, while import is probably not compatible but the only breaking rule should be no-unused-modules, which we specifically don't use (as noted in the FAQS)

[lishaduck]

I think that import-x is already compatible with V9, while import is probably not compatible but the only breaking rule should be no-unused-modules, which we specifically don't use (as noted in the FAQS)

Yeah, I guess you're right about that. I think a PR for ESLint 9 might be coming ~soon (in a month, if you haven't done so yourself¹)!

Footnotes

1. I have my Mac through my school, and I have to return it. I'll get it back mid-August, but until then I'll be on my Windows machine, and it's rather slow and isn't full of space. I can't spend 5 or 6 gigs of space on OSS contributions. Sorry 🙃 Be back soon. ↩

[AndreaPontrandolfo]

Tracking milestone: https://github.com/AndreaPontrandolfo/sheriff/milestone/1

[AndreaPontrandolfo]

Related issue

[AndreaPontrandolfo]

Full support for ESLint v9 landed with release 20.
As time goes goes on, we will probably remove all fixupPluginRules() call instances, gradually. But that's a minor detail.

This discussion is now resolved.