-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use any copula from Copulas.jl
#42
Comments
Hi! Thanks for opening this. Yes, I think this would be beneficial. We originally had BivariateCopulas.jl as a dependence, but we decided to re-implement here as we were playing with some new ideas. I think moving to your more general package would be great. I don't think it's very difficult, but there are a couple of features I'd like to keep.
In short, I think a copula type should be kept (maybe calling it something else), and move all the cdf and sampling calls to your package. |
Thanks for all these precise informations.
Hum... Intervals seems not to comply to the abstractfloat standard. What about using Measurements ?
is probably the way to go. I'll try to address some of these once I have some time upfront. Thanks :) |
I now implemented Furthermore, I think that the computation of the grid points should stay in Do you think the tests of this repo are enough to allow me to make these changes without breaking anything you need ? If you feel confortable abut this, i'll try to make a PR that passes your tests. |
Hey,
What would be needed for your code to use any copulas from
Copulas.jl
? It might reduce maintenability burden in yourcopulas.jl
file, and allow for many more parametric (or non-parametric) copula assumptions, as the possibilities ofCopulas.jl
allow many more models that what you have here.If you are interested in making this move, I might try to sketch a PR, but I'll need your help ;)
It would also allow for multivariate pboxes.
The text was updated successfully, but these errors were encountered: