We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
const
Using global variables as in
ProbabilityBoundsAnalysis.jl/src/ProbabilityBoundsAnalysis.jl
Line 70 in 652700c
To fix this, I suggest grouping all the global variables into a mutable struct, which you refer to via a const global. See e.g.
mutable struct
https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/db9202ccd08402d05616442f395e88cb21f79b9b/src/intervals/precision.jl
for a similar design.
The text was updated successfully, but these errors were encountered:
Part of the review for the JuliaCon proceedings: JuliaCon/proceedings-review#96
Sorry, something went wrong.
Thank you for this suggestion. I have followed the example from IntervalArithmetic.jl. In future it would be good to also remove these globals
Successfully merging a pull request may close this issue.
Using global variables as in
ProbabilityBoundsAnalysis.jl/src/ProbabilityBoundsAnalysis.jl
Line 70 in 652700c
is a performance trap.
To fix this, I suggest grouping all the global variables into a
mutable struct
, which you refer to via aconst
global. See e.g.https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/db9202ccd08402d05616442f395e88cb21f79b9b/src/intervals/precision.jl
for a similar design.
The text was updated successfully, but these errors were encountered: