Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LICENSE for the original R package #28

Open
dpsanders opened this issue Feb 7, 2022 · 2 comments · Fixed by #35
Open

Include LICENSE for the original R package #28

dpsanders opened this issue Feb 7, 2022 · 2 comments · Fixed by #35

Comments

@dpsanders
Copy link

I think (part of?) the license for the original R package needs to be included somehow in the LICENSE file, or at least mentioned. I'm not familiar with the rules for GPL.

@dpsanders
Copy link
Author

Part of the review for the JuliaCon proceedings: JuliaCon/proceedings-review#96

@AnderGray
Copy link
Owner

Good spot. I've been in touch with the pba.r developers, and they said that if this was an issue, the GPL is probably not the best license for pba.r, let alone this package.

About 50% of the code is a port of R. And I've made explicit note of this in the header of each src file where this is relevant, including a link to the original R code. Since the R code is open-source on GitHub, I don't believe the original source code for that package needs to be distributed here. I have also made an explicit note of this in the LICENSE.

Eventually I'd like to completely recode those files to make it more Julian, and perhaps change the license to MIT. But hopefully for now you agree that this is an appropriate fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants