Add ratio preview to videos #642

aaronkerckhoff · 2022-06-09T20:26:56Z

I added the ability to see the like/dislike ratio next to every video:

cyrildtm · 2022-06-09T21:44:48Z

Just to let you know, there is a different extension that has this feature: Thumbnail Rating Bar for YouTube™

In the above extension they have a delay function to slow down the for-loop for RYD API server queries, and a local cache to temporarily store query results for up to ten minutes. They acknowledged the limits by implementing this feature so individual users don't get banned by RYD API server.

It's nice to see you are implementing this function here, but would you consider including the delay and cache as well? That may prevent massive server requests, which is basically 100x traffic amplification.

cache: https://github.com/elliotwaite/thumbnail-rating-bar-for-youtube/blob/master/extension/background.js
delay: https://github.com/elliotwaite/thumbnail-rating-bar-for-youtube/blob/1ba786dcf6620310377d194b6b71919fbcf41d30/extension/content-script.js#L2

aaronkerckhoff · 2022-06-09T21:57:04Z

Just to let you know, there is a different extension that has this feature: Thumbnail Rating Bar for YouTube™

In the above extension they have a delay function to slow down the for-loop for RYD API server queries, and a local cache to temporarily store query results for up to ten minutes. They acknowledged the limits by implementing this feature so individual users don't get banned by RYD API server.

It's nice to see you are implementing this function here, but would you consider including the delay and cache as well? That may prevent massive server requests, which is basically 100x traffic amplification.

cache: https://github.com/elliotwaite/thumbnail-rating-bar-for-youtube/blob/master/extension/background.js delay: https://github.com/elliotwaite/thumbnail-rating-bar-for-youtube/blob/1ba786dcf6620310377d194b6b71919fbcf41d30/extension/content-script.js#L2

Thank you very much for that information. I also thought about that problem and thought that it would be a good idea to allow getting data for multiple videos at once. For example, I send a list with all videos on my start page [Sjfdyj5s, ...] and then get a list with all the data at once by the API. But as far as I know, the API isn't open source.

I really appreciate the links to the other extension. I'm not here for the weekend but I will work on this as soon as I come back.

sy-b · 2022-06-10T04:04:34Z

Another idea from discord (by Ezed)-

Most of the time users are going to ignore that extra info. Hence, it isn't necessary display it on all videos.
A better way can be to display the ratio on hover.

We should probably add some delay to that too.

cyrildtm · 2022-06-10T05:22:45Z

Most of the time I ignore the front page and go straight to my subscription and watch list. And I don't watch any instruction videos on Youtube because I find it less effective than more serious websites such as stackoverflow which allows peer review and discussion.
Yet I still keep the other extension open and I can tell in a fraction of a second if a video is controversy or apparently performing badly, just from the color. This is the time I want to see everything at a glance.

Maybe make a switch for the continuous-fire mode (with delay) and semi-auto mode (less or no delay).

Anarios#641 only for English

aaronkerckhoff · 2022-06-10T15:40:17Z

Another idea from discord (by Ezed)-

Most of the time users are going to ignore that extra info. Hence, it isn't necessary display it on all videos. A better way can be to display the ratio on hover.

We should probably add some delay to that too.

Thanks for this suggestion. This is a good idea. Maybe the ability to switch between the modes would be good idea? (Off, Only on hover, Always). With the "always-mode" using the delay and caching.

aaronkerckhoff · 2022-06-10T15:43:26Z

Maybe make a switch for the continuous-fire mode (with delay) and semi-auto mode (less or no delay).

Do you mean with "continuous-fire-mode" that the ratio is always displayed and with "semi-auto-mode" that it is only displayed on hover but then without delay?

cyrildtm · 2022-06-10T15:45:27Z

Another idea from discord (by Ezed)-
Most of the time users are going to ignore that extra info. Hence, it isn't necessary display it on all videos. A better way can be to display the ratio on hover.
We should probably add some delay to that too.

Thanks for this suggestion. This is a good idea. Maybe the ability to switch between the modes would be good idea? (Off, Only on hover, Always). With the "always-mode" using the delay and caching.

That sounds good.
I would recommend using cache for hover mode, too. Increases responsiveness and slightly reduces server load.

Maybe make a switch for the continuous-fire mode (with delay) and semi-auto mode (less or no delay).

Do you mean with "continuous-fire-mode" that the ratio is always displayed and with "semi-auto-mode" that it is only displayed on hover but then without delay?

Yeah, but my phrasing is a bit dark.

aaronkerckhoff · 2022-06-10T16:37:57Z

Alright, thank you. I will work on the different modes as well as the caching/delaying as soon as I can.

sy-b · 2022-06-11T03:40:41Z

Great 👍

cyrildtm · 2022-07-06T06:02:04Z

@aaronkerckhoff Thanks for your effort!

return-youtube-dislike/Extensions/combined/popup.js

Line 2 in 621dd8f

const config = {

Please add default value here:

  ratioPreview: "never",

Also add default value here, with comment:

return-youtube-dislike/Extensions/combined/ryd.background.js

Line 7 in 621dd8f

let extConfig = {

  ratioPreview: "never", // always, hover, never

Once more here:

return-youtube-dislike/Extensions/combined/src/state.js

Line 18 in 621dd8f

let extConfig = {

return-youtube-dislike/Extensions/combined/src/preview.js

Line 66 in 621dd8f

console.log('USING CACHE!!! for ' + videoId);

Please use our custom console log -- in the future it will be turned off by default

    cLog('USING CACHE!!! for ' + videoId);

import it from ./util.js

return-youtube-dislike/Extensions/combined/src/preview.js

Line 75 in 621dd8f

return;

I suggest you return a boolean false here

return-youtube-dislike/Extensions/combined/src/preview.js

Line 55 in 621dd8f

for (let key in cache) {

If I'm getting it right, if I choose "always" for the custom option, and when I open a list like subscription list, where there're hundreds of videos, then this for loop will be called hundreds of times. Even if my cache is less than 10 minutes old, the first test in the first iteration will always be executed, with time now being very close (batch executed for a list of videos). It's a small amount of wasted computation, which will add to the heat. It's pretty hot in the northern hemisphere now, and I hope not to waste too much electricity.

Here's a challenge: How to run cache cleanup only once for each page load?

return-youtube-dislike/Extensions/combined/src/preview.js

Line 38 in 621dd8f

let ratio = Math.round(likes / (likes + dislikes) * 100);

to prevent divide by zero error:

    let ratio = Math.round(likes / (likes + dislikes) * 100) || 0;

(More in my next post)

return-youtube-dislike/Extensions/combined/src/preview.js

Line 4 in 621dd8f

let videos = [];

return-youtube-dislike/Extensions/combined/src/preview.js

Line 47 in 621dd8f

videos.push(video);

return-youtube-dislike/Extensions/combined/ryd.content-script.js

Line 54 in 621dd8f

resetVideoList();

What's your plan with variable videos?

return-youtube-dislike/Extensions/combined/popup.js

Line 235 in 621dd8f

console.log('test');

(don't forget)

return-youtube-dislike/Extensions/combined/src/events.js

Line 83 in 621dd8f

function storageChangeHandler(changes, area) {

Here in event.js (will be merged into content-script.js), implement again the storage change handler. I don't remember exactly, but this part may be different than other appearances, although they are all called "storage change handlers". So be patient.

cyrildtm · 2022-07-06T06:08:43Z

return-youtube-dislike/Extensions/combined/src/preview.js

Line 36 in 621dd8f

let likes = data["likes"];

It's an on-going and one of our longest debates: whether or not to use API like data instead of official like data. The current implementation uses official, meaning (1) We don't use API by default, and (2) if official is unavailable we won't use API instead.

An example usage can be found here:

return-youtube-dislike/Extensions/combined/src/state.js

Line 158 in 15fa6ef

const nativeLikes = getLikeCountFromButton();

Also take a look at the few lines below; that's why I suggested returning false when response data is invalid.

return-youtube-dislike/Extensions/combined/src/preview.js

Line 38 in 621dd8f

let ratio = Math.round(likes / (likes + dislikes) * 100);

To really manage invalid cases:

    if (isNaN(likes) || isNaN(dislikes)) {
        return 0;
    } else {
      let ratio = Math.round(likes / (likes + dislikes) * 100) || 0;
    }

aaronkerckhoff · 2022-07-08T23:32:30Z

Thank you very much for all your suggestions! I'm currently working on the implementation.

* Set default value * Remove debug console logs * Return false if data is invalid * Only clean cache on page change * Fix possible divide by zero error * Use official likes istead of API data * Prevent invalid cases in ratio calculation

aaronkerckhoff · 2022-07-10T09:54:03Z

Thank you very much for all of your suggestions and the time you spend on them. I fixed everything you mentioned.

What's your plan with variable videos?
In an interval of 3 seconds, all videos on the page are gathered. Every video then gets the addition of the ratio display. As soon as it displays the ratio, it gets added to the list videos. This is to prevent every video from being updated every 3 seconds, but only new videos (for example when scrolling down).

Revert "Add ratio display to new design"

Create FUNDING.yml

Update Guide__Troubleshooting.md

Add Czech and fix Japanese

Revert "Add Czech and fix Japanese"

Develop

TEMPORARILY UNAVAILABLE -> TEMP N/A

aaronkerckhoff · 2022-08-04T00:27:33Z

Sorry that I didn't update this PR sooner, I was really busy in the last few months. I now added the ability to toggle the different modes: always, hover, never. Everything works fine so far, if there are still some bugs, let me know. Thanks to all that helped me and contributed to this PR.

aaronkerckhoff added 2 commits June 9, 2022 20:35

Add ratio preview to videos

e4b4a21

Update ratio preview when going back to previous page

74f5e56

aaronkerckhoff marked this pull request as draft June 9, 2022 22:00

TEMPORARILY UNAVAILABLE -> TEMP N/A

455a672

Anarios#641 only for English

Fjuro added 5 commits June 10, 2022 19:51

Create cs/messages.json

167b839

Create cs.ts

af8910c

Add Czech and Japanese

276daa2

Add Czech and Japanese

2cd4c1a

Add Czech and Japanese

8647295

Fjuro and others added 11 commits June 15, 2022 17:08

Update links.vue

79aa5ad

Update default.vue

bda7e6c

Update Guide__Troubleshooting.md

e7496a3

Unify quotation marks

65627f7

Improve coloring

a52170a

Add ratio preview modes to menu

982aa97

Format mode selection in menu

f3049eb

Create FUNDING.yml

11fc02b

fix FUNDING.yml custom url

c855267

Add caching

621dd8f

Add ratio preview to channel overviews

6d48477

Improve ratio display

5c3993c

* Set default value * Remove debug console logs * Return false if data is invalid * Only clean cache on page change * Fix possible divide by zero error * Use official likes istead of API data * Prevent invalid cases in ratio calculation

Fix security vulnerabilities

f6aa2ee

cyrildtm mentioned this pull request Jul 17, 2022

(Feature Request): show ratio on searches #680

Open

2 tasks

Anarios added 8 commits July 19, 2022 23:49

Merge pull request Anarios#681 from Anarios/revert-622-main

117b483

Revert "Add ratio display to new design"

Merge pull request Anarios#655 from PickleNik/main

6018bd1

Create FUNDING.yml

Merge pull request Anarios#653 from sy-b/patch-2

2cb30aa

Update Guide__Troubleshooting.md

Merge pull request Anarios#644 from Fjuro/patch-1

3231369

Add Czech and fix Japanese

Revert "Add Czech and fix Japanese"

343f213

Merge pull request Anarios#683 from Anarios/revert-644-patch-1

6045409

Revert "Add Czech and fix Japanese"

Merge pull request Anarios#684 from Anarios/develop

19b381d

Develop

Merge pull request Anarios#643 from afnzmn/patch-1

fd49f02

TEMPORARILY UNAVAILABLE -> TEMP N/A

Anarios changed the base branch from main to develop July 19, 2022 22:20

aaronkerckhoff and others added 2 commits July 24, 2022 18:11

Merge branch 'Anarios:main' into ratio-preview

2338c69

Add different ratio preview modes

34c0a2e

aaronkerckhoff marked this pull request as ready for review August 4, 2022 00:25

sy-b mentioned this pull request Aug 11, 2022

Broken Dislikes on Shorts UI (for normal and for the likes disabled) #723

Closed

aaronkerckhoff added 2 commits November 13, 2022 00:57

Fix ratio preview for new design

70d8d8d

Fix ratio preview not disappearing

da263bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ratio preview to videos #642

Add ratio preview to videos #642

aaronkerckhoff commented Jun 9, 2022

cyrildtm commented Jun 9, 2022

aaronkerckhoff commented Jun 9, 2022 •

edited

Loading

sy-b commented Jun 10, 2022 •

edited

Loading

cyrildtm commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

cyrildtm commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

sy-b commented Jun 11, 2022

cyrildtm commented Jul 6, 2022 •

edited

Loading

cyrildtm commented Jul 6, 2022 •

edited

Loading

aaronkerckhoff commented Jul 8, 2022

aaronkerckhoff commented Jul 10, 2022

aaronkerckhoff commented Aug 4, 2022

Add ratio preview to videos #642

Are you sure you want to change the base?

Add ratio preview to videos #642

Conversation

aaronkerckhoff commented Jun 9, 2022

cyrildtm commented Jun 9, 2022

aaronkerckhoff commented Jun 9, 2022 • edited Loading

sy-b commented Jun 10, 2022 • edited Loading

cyrildtm commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

cyrildtm commented Jun 10, 2022

aaronkerckhoff commented Jun 10, 2022

sy-b commented Jun 11, 2022

cyrildtm commented Jul 6, 2022 • edited Loading

cyrildtm commented Jul 6, 2022 • edited Loading

aaronkerckhoff commented Jul 8, 2022

aaronkerckhoff commented Jul 10, 2022

aaronkerckhoff commented Aug 4, 2022

aaronkerckhoff commented Jun 9, 2022 •

edited

Loading

sy-b commented Jun 10, 2022 •

edited

Loading

cyrildtm commented Jul 6, 2022 •

edited

Loading

cyrildtm commented Jul 6, 2022 •

edited

Loading