Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More color schemes #568

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

More color schemes #568

wants to merge 14 commits into from
+452 −149

Conversation

cyrildtm
Copy link
Contributor

@cyrildtm cyrildtm commented Apr 24, 2022 •
edited
Loading

fix #552
resolve #571

cyrildtm and others added 5 commits April 24, 2022 17:09
@cyrildtm
(extension) more color themes
0f57772 
resolves Anarios#552
@cyrildtm
cherry pick Anarios#540
1f6e001 
Userscript custom colors

using user options Anarios#539

Userscript user options

introduce user options to userscript. Using existing options available in extension for now, plus showing update popup.
Part of Anarios#539

userscript custom number formats

using user options Anarios#539
resolves Anarios#520
@cyrildtm
(userscript) more colors
56990bf
@cyrildtm
(userscript) fix color names
02899b8 
userscript does not use account storage, so no need for backward compatibility
@cyrildtm
cherrypick Anarios#567
d125085 
(userscript) fix shorts thumb colors

related: Anarios#540

(extension) fix shorts thumb colors

fix Anarios#565
@cyrildtm
Copy link
Contributor Author

cyrildtm commented Apr 24, 2022 •
edited
Loading

Two problems:
1. Need custom color implementation (TODO)
2. In popup.html, How to add a data-hover attribute for "Color theme"?
all done

@cyrildtm
Copy link
Contributor Author

cyrildtm commented Apr 25, 2022 •
edited
Loading

TODO New color theme: Nostalgic --done
#571

Bar (unrated):
Likes #909090
Dislikes #cccccc

Bar (rated)
Likes #0450dc
Dislikes #cccccc

the dislikes portion of the rate bar is #606060 in dark mode

Needs mutation observer to monitor like/dislike/neutral state. Try utilize isVideoLiked() and isVideoDisliked(). Why not likeClicked() or processResponse()? Not a consolidated place.

Thumbs color: #909090 May need to adjust style to fill neutral thumbs, but do not interfere with isVideoLiked() detection technique. Thumbs are replaced with totally different SVGs (filled vs hollow) when switching states. Unfortunately, without copyright infringement these SVGs cannot be included in this plugin. Need to think of any workaround to make up.

Bar and thumbs can still be controlled separately, although to get a full 2018 experience one needs both.

Incompatible with Shorts. slightly different behaviors with Shorts: either blue or default grey.

cyrildtm added 4 commits April 26, 2022 19:46
@cyrildtm
Merge branch 'main' into ColorizedButtonsAndBar-New
9d3e8b8
@cyrildtm
Merge branch 'main' into ColorizedButtonsAndBar-New
8ff872e
@cyrildtm
cherry pick Anarios#592
97fc28a 
add hover labels for select list label

cherry pick Anarios#541 (prettify popup)

prettify popup

add scrollbar
add hover fade-in animation

Make popup scroll bar consistent with website

use black/red color scheme and half-rounded shape
@cyrildtm
new color scheme: nostalgia
20c4606 
feature request Anarios#571
@cyrildtm cyrildtm marked this pull request as ready for review May 8, 2022 07:56
@PickleNik PickleNik requested a review from Anarios May 17, 2022 19:26
@PickleNik
Copy link
Collaborator

thought this would be in 3.0.0.2, @Anarios ples merge, people are begging on Discord 🙏

@cyrildtm cyrildtm mentioned this pull request Jun 13, 2022
Closed
@Anarios Anarios changed the base branch from main to develop July 19, 2022 22:01
@cyrildtm cyrildtm mentioned this pull request Jul 20, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anarios Anarios Awaiting requested review from Anarios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cyrildtm @PickleNik