-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dislike Information Panel #564
base: main
Are you sure you want to change the base?
Conversation
fixed ``` \return-youtube-dislike\Website\pages\index.vue 129:198 error Unnecessary escape character: \/ no-useless-escape ```
uses --> use
Note: Adding button inside YT Player -> idea from SponsorBlock |
Please suggest a better UI or make one if you can. |
Speaking of trust level, perhaps we can come up with an empirical model with some maths and programming. if some-- as many as possible-- video uploaders can share their studio data , we may examine the links between these variables: subscribers, views, likes dislikes, ratio. We assume the more extension users the more accurate, but by how much? This quantified concept can become trust level |
This starts the question of "secure sharing & verification of data".
While writing #114, I was assuming that creators would upload the data on a regular basis and we'll use these variables
After the idea of TLS modification method
This now seems unrealistic to me. |
If we come up with an empirical model, we can just use much fewer existing video sentiments to calibrate it, so no need to constantly upload latest counts for every video. Using a model solves the eternal problem of sharing vs security. |
Converting to draft as it is not ready yet. I think the logo in the player could be a tad smaller to match everything else better |
👍
Depends on @Anarios. I am waiting for the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use Socal Blade for this ngl
👍 |
In fact, perhaps instead of embedding that giant panel for detailed data, that can go in the extension popup? |
That would require message exchange, which is a bit complicated, but it's doable, if desired. |
Pros & Cons of this panel
I am inclined to reimplement this the way SponsorBlock has if we extpand its purpose. function sendRequestToCustomServer(type, fullAddress, callback) {
const xmlhttp = new XMLHttpRequest();
xmlhttp.open(type, fullAddress, true);
if (callback != undefined) {
xmlhttp.onreadystatechange = function () {
callback(xmlhttp, false);
};
xmlhttp.onerror = function() {
callback(xmlhttp, true);
};
}
//submit this request
xmlhttp.send();
} This way we can have the same pages shown in popup & panel. Also, having these pages in a separate folder will be better. |
Yeah, but this is inaccessible to mobile users.
Judging by the amount of people asking "How to get to the extension setting menu for colors", I can very well say that many people can easily find chrome://extension/whatever-extension-id than a settings button in the extension popup.
I agree. |
Is this really a use case we should consider? Vanced is by no means dead (the old version works, will work for at least a year, and a new project is almost off the ground) and most others use 3rd party apps that add functionality like RYD. YouTube Web Mobile is trash, and the exclusive use case for touchscreen desktop tablets/2-1's is tiny. |
So true! I can't even watch a video full screen. Not to mention potato touch control. I never use mobile web version, avoid like plague
I have a 2-in-1, and I use full desktop version. Mobile UI is nonsense.
You see this is the problem with Chrome. Those smart people think they can educate the human species into knowing things inside the developer's brains. Truth is, no, people will get confused as always. |
Initial contributors did consider supporting it & most of the extension features are supported on mobile. (I |
Maybe there's a way to detect long press? |
would be great if hovering the bar can shows more info like |
Comes after #533
This pr will be updated after the API change & then can be merged. Do not merge unless you want to ask users about their views suggestions.
Wouldn't work as expected
Required API fields
partially fixes #114
Originally posted in issuecomment-1109344899
Pros & Cons of this panel
Pros
Cons
I am inclined to reimplement this the way SponsorBlock has if we extpand its purpose.
from: https://github.com/ajayyy/SponsorBlock/blob/0c216792cf1737e13e358411902f4b77dce1725e/src/content.ts#L2095-L2112
Also refer: https://github.com/ajayyy/SponsorBlock/blob/0c216792cf1737e13e358411902f4b77dce1725e/src/content.ts#L1666-L1733
This way we can have the same pages shown in popup & panel. Also, having these pages in a separate folder will be better.
@Anarios Can you add these fields? Or are you planning to add another endpoint for extension user data?