Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless JDK's cause crashes #49

Closed
2 tasks done
Y1rd opened this issue May 23, 2024 · 10 comments
Closed
2 tasks done

Headless JDK's cause crashes #49

Y1rd opened this issue May 23, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@Y1rd
Copy link

Y1rd commented May 23, 2024

Does an issue already cover this?

  • I have searched for any existing issues, and didn't find any.

Does your system support Faster Random?

  • I have checked that my JVM supports Faster Random 3.0.0+.

Issue description.

If you are on a linux distro and using Wayland window manager (e.g. hyprland), the game will crash upon startup.

Issue replication.

  1. Run a Wayland window manager
  2. Start Minecraft with the mod installed

Log File / Crash Report (if applicable)

https://mclo.gs/tOXu1K7
(Note: Ignore Mod Menu conflict, it does not crash the game.)

@Y1rd Y1rd added the bug Something isn't working label May 23, 2024
@AnOpenSauceDev
Copy link
Owner

This is technically not an issue with X11 or Wayland at all. What's happening is that your JVM does not support L64X128MixRandom (Line 330), and the popup warning you about that is likely crashing the game (because wayland likely hates that).

@AnOpenSauceDev AnOpenSauceDev closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
@AnOpenSauceDev AnOpenSauceDev changed the title [BUG]: Game crash if X11 isn't set by the window manager Warning popup causes a crash on Wayland May 23, 2024
@Y1rd
Copy link
Author

Y1rd commented May 23, 2024

Ah, thanks.
I'm using OpenJDK 22, so I assume that is the issue I guess.

@AnOpenSauceDev
Copy link
Owner

That shouldn't be a problem, Faster Random just needs JEP 356 implemented. It's strange that OpenJDK 22 of all things is having trouble with it considering that OpenJDK's above 17 should have this implemented.

@Y1rd
Copy link
Author

Y1rd commented May 23, 2024

That shouldn't be a problem, Faster Random just needs JEP 356 implemented. It's strange that OpenJDK 22 of all things is having trouble with it considering that OpenJDK's above 17 should have this implemented.

I just started up the game with OpenJDK 17 and it booted just fine, is OpenJDK 22 missing JEP 356?

@AnOpenSauceDev
Copy link
Owner

Must be. What is the actual name of the JDK, and did you get it from your package manager?

@Y1rd
Copy link
Author

Y1rd commented May 23, 2024

Must be. What is the actual name of the JDK, and did you get it from your package manager?

So, I figured out the issue. I had jre-openjdk-headless installed instead of jdk-openjdk. Woops.
OpenJDK 22 works just fine now.

On another note, I'm suprised Minecraft worked with headless jre and I never noticed until now.

@AnOpenSauceDev
Copy link
Owner

I wonder if that's the major cause of so many people having the wrong JDK. Not only does it seem to not have the generators for some reason, displaying the popup will cause a crash due to it being headless.

Minecraft probably works fine since LWJGL talks to many native libraries which could bypass Java's systems.

@AnOpenSauceDev AnOpenSauceDev pinned this issue May 23, 2024
@AnOpenSauceDev AnOpenSauceDev changed the title Warning popup causes a crash on Wayland Headless JDK's cause crashes May 23, 2024
@Y1rd
Copy link
Author

Y1rd commented May 23, 2024

Huh, guess we've uncovered something interesting.

@AnOpenSauceDev
Copy link
Owner

It's more interesting in the case of: "Why isn't RandomGenerator included in a version of a JDK that only should remove some graphical/input features?" It's quite annoying, and I don't really have a way to tell users that they have a broken package without spawning another process (which in light of recent events, is a bad idea).

@Y1rd
Copy link
Author

Y1rd commented May 23, 2024

Was going to say to edit the jvm list, but you already did.
Also, yeah... and it seems kinda silly to remove that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants