fix(linkedin): use case-insensitive slug check to prevent missing image #2205
Conversation
📝 WalkthroughWalkthroughThe change updates the conditional logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant CI as BrandIcon Component
participant SL as Slug Property
CI ->> SL: Receive slug value
CI ->> CI: Convert slug to lowercase
CI ->> CI: Check if lowercase slug equals "linkedin"
alt If match is found
CI ->> CI: Render LinkedIn Icon
else
CI ->> CI: Render default image
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/artboard/src/components/brand-icon.tsx (1)
8-8: LGTM! Consider adding null/undefined check for additional robustness.The case-insensitive check effectively solves the issue of missing LinkedIn images for different capitalizations.
For additional robustness, consider adding a null/undefined check:
- if (slug.toLowerCase() === "linkedin") { + if (slug?.toLowerCase() === "linkedin") {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/artboard/src/components/brand-icon.tsx(1 hunks)
🔇 Additional comments (1)
apps/artboard/src/components/brand-icon.tsx (1)
8-17: Verify other potential case-sensitive brand checks in the codebase.Let's ensure there aren't other similar case-sensitive brand name checks that might need the same treatment.
✅ Verification successful
Verification of Case-Sensitive Brand Checks
Our search indicates that the only instance of a case-sensitive brand name check is in
apps/artboard/src/components/brand-icon.tsxfor "LinkedIn". No additional patterns for GitHub, Twitter, or Facebook using either thetoLowerCase()or direct equality check were found.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for potential case-sensitive brand name comparisons rg -i "=== ['\"].*(?i:linkedin|github|twitter|facebook)" --type ts --type tsx # Search for other potential brand icon components or similar patterns ast-grep --pattern 'if ($slug === $value) { $$$ }'Length of output: 163
Script:
#!/bin/bash # Search for brand name comparisons using slug.toLowerCase() for common brands in both .ts and .tsx files rg -i "if\s*\(\s*slug\.toLowerCase\(\)\s*===\s*['\"](linkedin|github|twitter|facebook)['\"]" --glob "*.{ts,tsx}" # Also search for direct slug equality checks with these brand names (without converting to lowercase) rg -i "if\s*\(\s*slug\s*===\s*['\"](linkedin|github|twitter|facebook)['\"]" --glob "*.{ts,tsx}"Length of output: 307
|
@ImDarkShadow @ilatypov @gzsombor I have raised defect since week but no response over it. I am actively applying for the job and require resume export from your website https://rxresu.me/ |
|
Hi @skatkoria, I’m not an active contributor to this project, and my knowledge of it is somewhat limited. However, I noticed your comment and attempted to reproduce the issue, but was unable to do so. If you could provide the relevant JSON, I’d be happy to take another look and see if there’s anything I can help with. Please note that this is the Pull Request section, not the Issues section. For future reference, issues should be discussed in the appropriate section. Additionally, I would recommend using a different template for PDF export, as this project is maintained by a sole developer, and responses may take some time. Thank you for your understanding! |
Summary:
Fixes an issue where varying capitalizations of "linkedin" (e.g., "LinkedIn") resulted in an empty image by making the slug check case-insensitive.
Changes Made:
Summary by CodeRabbit