Merge pull request #1389 from AmbireTech/add/insufficient-eth-error-humanization

Add/ Error humanization for "Insufficient ETH for transaction calls"

Author: PetromirDev

src/libs/errorDecoder/errorDecoder.test.ts

@@ -377,7 +377,7 @@ describe('Error decoders work', () => {
     expect(decodedError.reason).toBe(`Insufficient ${base.nativeAssetSymbol} for transaction calls`)
     const humanized = getHumanReadableEstimationError(decodedError)
     expect(humanized.message).toBe(
-      `The transaction will fail because it will revert onchain. Error code: Insufficient ${base.nativeAssetSymbol} for transaction calls\n`
+      "The transaction will fail because you don't have enough ETH to cover the gas costs for this transaction."
     )
 
     const sameErrorOnAvax = new InnerCallFailureError(
@@ -392,7 +392,7 @@ describe('Error decoders work', () => {
     )
     const humanizedAvax = getHumanReadableEstimationError(decodedsameErrorOnAvax)
     expect(humanizedAvax.message).toBe(
-      `The transaction will fail because it will revert onchain. Error code: Insufficient ${avalanche.nativeAssetSymbol} for transaction calls\n`
+      "The transaction will fail because you don't have enough AVAX to cover the gas costs for this transaction."
     )
   })
   it('Should report transaction reverted with error unknown when error is 0x and the calls value is less or equal to the portfolio amount', async () => {

src/libs/errorHumanizer/errors.ts

@@ -56,6 +56,24 @@ const BROADCAST_OR_ESTIMATION_ERRORS: ErrorHumanizerError[] = [
     reasons: ['Transaction underpriced'],
     message: 'it is underpriced. Please select a higher transaction speed and try again.'
   },
+  // TODO: Figure out a more elegant way to handle errors with dynamic messages
+  {
+    reasons: ['Insufficient ETH for transaction calls'],
+    message: "you don't have enough ETH to cover the gas costs for this transaction."
+  },
+  {
+    reasons: ['Insufficient AVAX for transaction calls'],
+    message: "you don't have enough AVAX to cover the gas costs for this transaction."
+  },
+  {
+    reasons: ['Insufficient BNB for transaction calls'],
+    message: "you don't have enough BNB to cover the gas costs for this transaction."
+  },
+  {
+    reasons: ['Insufficient POL for transaction calls'],
+    message: "you don't have enough POL to cover the gas costs for this transaction."
+  },
+  // End of TODO
   // Smart Accounts
   {
     reasons: ['Sponsorship failed.'],

src/libs/estimate/estimate.test.ts

@@ -932,7 +932,7 @@ describe('estimate', () => {
 
     expect(response instanceof Error).toBe(true)
     expect((response as Error).message).toBe(
-      'The transaction will fail because it will revert onchain. Error code: Insufficient ETH for transaction calls\n'
+      "The transaction will fail because you don't have enough ETH to cover the gas costs for this transaction."
     )
   })
 
@@ -1117,7 +1117,7 @@ describe('estimate', () => {
     )
     expect(response instanceof Error).toBe(true)
     expect((response as Error).message).toBe(
-      'The transaction will fail because it will revert onchain. Error code: Insufficient POL for transaction calls\n'
+      "The transaction will fail because you don't have enough POL to cover the gas costs for this transaction."
     )
   })