Skip to content

Commit

Permalink
Merge pull request #50 from Amateur-God:optimisations
Browse files Browse the repository at this point in the history
Optimisations
  • Loading branch information
Amateur-God authored Nov 3, 2024
2 parents 2e653ad + fa67c3c commit c5c31c1
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions custom_components/technitiumdns/sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,10 @@ async def _async_update_data(self):
try:
_LOGGER.debug("Fetching data from TechnitiumDNS API")
Technitiumdns_statistics = await self.api.get_statistics(self.stats_duration)
Technitiumdns_top_clients = await self.api.get_top_clients(self.stats_duration)
Technitiumdns_top_domains = await self.api.get_top_domains(self.stats_duration)
Technitiumdns_top_blocked_domains = await self.api.get_top_blocked_domains(self.stats_duration)
Technitiumdns_update_info = await self.api.check_update()

# Add more logging to debug empty response issue
# Add logging to debug response content
_LOGGER.debug("Technitiumdns_statistics response content: %s", Technitiumdns_statistics)
_LOGGER.debug("Technitiumdns_top_clients response content: %s", Technitiumdns_top_clients)
_LOGGER.debug("Technitiumdns_top_domains response content: %s", Technitiumdns_top_domains)
_LOGGER.debug("Technitiumdns_top_blocked_domains response content: %s", Technitiumdns_top_blocked_domains)
_LOGGER.debug("Technitiumdns_update_info response content: %s", Technitiumdns_update_info)

Technitiumdns_stats = Technitiumdns_statistics.get("response", {}).get("stats", {})
Expand All @@ -85,15 +79,15 @@ async def _async_update_data(self):
"block_list_zones": Technitiumdns_stats.get("blockListZones", 0),
"top_clients": [
{"name": client.get("name", "Unknown"), "hits": client.get("hits", 0)}
for client in Technitiumdns_top_clients.get("response", {}).get("topClients", [])[:5]
for client in Technitiumdns_statistics.get("response", {}).get("topClients", [])[:5]

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Line too long (104/100) Warning

Line too long (104/100)

Check warning

Code scanning / Pylint (reported by Codacy)

Line too long (104/100) Warning

Line too long (104/100)
],
"top_domains": [
{"name": domain.get("name", "Unknown"), "hits": domain.get("hits", 0)}
for domain in Technitiumdns_top_domains.get("response", {}).get("topDomains", [])[:5]
for domain in Technitiumdns_statistics.get("response", {}).get("topDomains", [])[:5]

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Line too long (104/100) Warning

Line too long (104/100)

Check warning

Code scanning / Pylint (reported by Codacy)

Line too long (104/100) Warning

Line too long (104/100)
],
"top_blocked_domains": [
{"name": domain.get("name", "Unknown"), "hits": domain.get("hits", 0)}
for domain in Technitiumdns_top_blocked_domains.get("response", {}).get("topBlockedDomains", [])[:5]
for domain in Technitiumdns_statistics.get("response", {}).get("topBlockedDomains", [])[:5]

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Line too long (111/100) Warning

Line too long (111/100)

Check warning

Code scanning / Pylint (reported by Codacy)

Line too long (111/100) Warning

Line too long (111/100)
],
}
_LOGGER.debug("Data combined: %s", data)
Expand Down

0 comments on commit c5c31c1

Please sign in to comment.