ci: updated NuGet version strategy #1948
Conversation
|
Warning Rate limit exceeded@Fargekritt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 0 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates the version formatting for the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-cd-main.yml(1 hunks).github/workflows/ci-cd-staging.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/ci-cd-staging.yml
87-87: property "generate-git-short-sha" is not defined in object type {check-for-changes: {outputs: {hasbackendchanges: string; hasgqlschemachanges: string; hasinfrachanges: string; hasmigrationchanges: string; hasslacknotifierchanges: string; hasswaggerschemachanges: string; hastestchanges: string; haswebapiclientchanges: string}; result: string}; deploy-apps: {outputs: {deployment_executed: string}; result: string}}
(expression)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Dry run deploy infrastructure / Deploy to test
🔇 Additional comments (1)
.github/workflows/ci-cd-main.yml (1)
106-108: Approved: Updated version string for NuGet publication
The version string has been updated to include the-alphapre-release identifier along with the Git short SHA, which aligns with the new NuGet versioning strategy for the primary environment. Ensure that any documentation or downstream tooling referencing version formats is updated accordingly.
| version: ${{ github.event.client_payload.version }}-rc+${{ needs.generate-git-short-sha.outputs.gitShortSha }} | ||
| path: 'src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj' | ||
| source: 'https://api.nuget.org/v3/index.json' |
There was a problem hiding this comment.
Critical: Missing dependency for git short SHA output
The updated version string now includes a reference to needs.generate-git-short-sha.outputs.gitShortSha. However, the publish-sdk-to-nuget job’s needs array does not include a job named generate-git-short-sha, which will cause an undefined output error at runtime. Please update the needs list to include the generate-git-short-sha job if it exists, or adjust the reference accordingly.
Suggested diff:
- needs: [ deploy-apps, check-for-changes ]
+ needs: [ deploy-apps, check-for-changes, generate-git-short-sha ]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| version: ${{ github.event.client_payload.version }}-rc+${{ needs.generate-git-short-sha.outputs.gitShortSha }} | |
| path: 'src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj' | |
| source: 'https://api.nuget.org/v3/index.json' | |
| jobs: | |
| publish-sdk-to-nuget: | |
| - needs: [ deploy-apps, check-for-changes ] | |
| + needs: [ deploy-apps, check-for-changes, generate-git-short-sha ] | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Publish to NuGet | |
| with: | |
| version: ${{ github.event.client_payload.version }}-rc+${{ needs.generate-git-short-sha.outputs.gitShortSha }} | |
| path: 'src/Digdir.Library.Dialogporten.WebApiClient/Digdir.Library.Dialogporten.WebApiClient.csproj' | |
| source: 'https://api.nuget.org/v3/index.json' |
🧰 Tools
🪛 actionlint (1.7.4)
87-87: property "generate-git-short-sha" is not defined in object type {check-for-changes: {outputs: {hasbackendchanges: string; hasgqlschemachanges: string; hasinfrachanges: string; hasmigrationchanges: string; hasslacknotifierchanges: string; hasswaggerschemachanges: string; hastestchanges: string; haswebapiclientchanges: string}; result: string}; deploy-apps: {outputs: {deployment_executed: string}; result: string}}
(expression)
Fargekritt
changed the title
Description
Dev: {major}.{minor}.{patch}.{revision}-alpha+{gitsha}
Stage: {major}.{minor}.{patch}.{revision}-rc+{gitsha}
Prod: {major}.{minor}.{patch}.{revision}
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)