chore: updated push sdk to NuGet workflow on WebApiClient changes #1944
Conversation
📝 WalkthroughWalkthroughThe changes update several GitHub Actions workflow files to broaden the conditions for triggering the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/ci-cd-staging.yml (1)
85-85: Expanded NuGet Publishing Condition
The updated conditional now checks for both Swagger schema changes and WebApiClient modifications. This ensures that if either type of change occurs, the NuGet package is pushed. For clarity and consistency, consider confirming whether the value ofhasWebApiClientChangesshould be explicitly compared to'true'(as done with Swagger schema changes) in case the output is a string..github/workflows/ci-cd-main.yml (1)
104-104: Expanded NuGet Publishing Condition in Main Workflow
The conditional expression now correctly triggers thepublish-sdk-to-nugetjob when there are either Swagger schema changes or WebApiClient changes. Just verify that the type ofhasWebApiClientChangesis consistent with the explicit string comparison used forhasSwaggerSchemaChanges; if it is a string, an explicit comparison (e.g.== 'true') may improve readability..github/workflows/ci-cd-prod.yml (1)
105-105: Expanded NuGet Publishing Condition in Production Workflow
Similar to the main workflow, the production workflow now triggers the NuGet publishing job if there are Swagger schema changes or WebApiClient changes. Ensure that the output forhasWebApiClientChangesis of the expected type so that this conditional behaves consistently across environments.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci-cd-main.yml(1 hunks).github/workflows/ci-cd-prod.yml(1 hunks).github/workflows/ci-cd-staging.yml(1 hunks).github/workflows/workflow-check-for-changes.yml(3 hunks)
🔇 Additional comments (3)
.github/workflows/workflow-check-for-changes.yml (3)
23-25: New Output for WebApiClient Changes
The addition of thehasWebApiClientChangesoutput in the workflow’s outputs section is clear and well-documented. This new output will inform downstream jobs if any WebApiClient files have been modified.
54-54: Job Output Assignment for WebApiClient Changes
The job outputhasWebApiClientChangesis correctly derived by comparing theweb_api_client_modifiedoutput from thefilter-backendstep to'true'. This ensures only a truthy result triggers the output.
86-88: WebApiClient Files Configuration
The configuration for monitoring changes in the WebApiClient directory (i.e.'src/Digdir.Library.Dialogporten.WebApiClient/**/*') is clearly specified. This allows the workflow to reliably detect modifications to this code area and trigger related jobs accordingly.
🤖 I have created a release *beep* *boop* --- ## [1.55.4](v1.55.3...v1.55.4) (2025-02-24) ### Miscellaneous Chores * **performance:** remove warm-up step before performance tests ([#1942](#1942)) ([757f454](757f454)) * **sdk:** Update title for SDK README.md ([#1949](#1949)) ([b4139b1](b4139b1)) * updated push sdk to NuGet workflow on WebApiClient changes ([#1944](#1944)) ([b7186ba](b7186ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Description
WebApiClient NuGet is now also pushed on changes in the WebApiClient not only on schema changes
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)