Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(performance): remove warm-up step before performance tests #1942

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

dagfinno
Copy link
Collaborator

Description

Remove warm-up step before performance, e2e-test should be enough

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@dagfinno dagfinno requested review from a team as code owners February 24, 2025 05:59
Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

📝 Walkthrough

Walkthrough

This pull request removes the run-performance-warmup job from the CI/CD workflow configuration and updates the dependency for the run-performance-tests job so that it now runs after end-to-end tests (run-e2e-tests). The changes simplify the conditions for running performance tests and update the referenced test script filenames, reflecting a change in the testing strategy.

Changes

File Change Summary
.github/…/ci-cd-yt01.yml Removed the run-performance-warmup job; updated run-performance-tests job to depend on run-e2e-tests instead of the removed warmup job; simplified conditions and updated test script filenames.

Possibly related PRs

Suggested labels

performance, enhancement, tests

Suggested reviewers

  • oskogstad

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3b2799 and e8dce9d.

📒 Files selected for processing (1)
  • .github/workflows/ci-cd-yt01.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Dry run deploy infrastructure / Deploy to test
  • GitHub Check: build / build-and-test
🔇 Additional comments (1)
.github/workflows/ci-cd-yt01.yml (1)

112-117: Updated Dependency and Removal of the Warm-Up Phase
The run-performance-tests job now depends on [run-e2e-tests] rather than the removed run-performance-warmup job. This change is in line with the updated testing strategy that leverages the end-to-end tests to confirm system readiness before actual performance testing. Please verify that no other parts of the workflow (or related documentation) reference the removed warm-up step.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dagfinno dagfinno merged commit 757f454 into main Feb 24, 2025
23 checks passed
@dagfinno dagfinno deleted the performance/remove-warm-up branch February 24, 2025 08:23
oskogstad added a commit that referenced this pull request Feb 24, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.55.4](v1.55.3...v1.55.4)
(2025-02-24)


### Miscellaneous Chores

* **performance:** remove warm-up step before performance tests
([#1942](#1942))
([757f454](757f454))
* **sdk:** Update title for SDK README.md
([#1949](#1949))
([b4139b1](b4139b1))
* updated push sdk to NuGet workflow on WebApiClient changes
([#1944](#1944))
([b7186ba](b7186ba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants