Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add event for transmission created #1893

Merged
merged 2 commits into from
Feb 17, 2025
Merged

feat: Add event for transmission created #1893

merged 2 commits into from
Feb 17, 2025

Conversation

oskogstad
Copy link
Collaborator

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@oskogstad oskogstad requested a review from a team as a code owner February 16, 2025 22:19
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

This pull request introduces a new domain event, DialogTransmissionCreatedDomainEvent, and updates related components to handle it. A new event handler is added in the DialogEventToAltinnForwarder, and the cloud event types mapping is extended accordingly. The DialogTransmission entity now implements additional interfaces, includes methods for event publication, and stores domain events. Corresponding tests have been added and updated to validate the new transmission event handling and ensure that both update and transmission-created events are generated.

Changes

File(s) Change Summary
src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Events/AltinnForwarders/DialogEventToAltinnForwarder.cs Added an event handler for DialogTransmissionCreatedDomainEvent; implemented INotificationHandler<DialogTransmissionCreatedDomainEvent> and added the Handle method to publish a new CloudEvent.
src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Events/CloudEventTypes.cs Added a new case in the Get method mapping DialogTransmissionCreatedDomainEvent to "dialogporten.dialog.transmission.created.v1".
src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/Transmissions/DialogTransmission.cs Updated the class to implement IAggregateCreatedHandler and IEventPublisher; added private _domainEvents list, OnCreate, and PopDomainEvents methods to support event publishing.
src/Digdir.Domain.Dialogporten.Domain/Dialogs/Events/DialogTransmissionCreatedDomainEvent.cs Introduced a new record type encapsulating properties for the transmission created event; inherits from DomainEvent and implements IProcessEvent.
tests/Digdir.Domain.Dialogporten.Application.Integration.Tests/Features/V1/Common/Events/DomainEventsTests.cs Added test method Creates_Update_Event_And_Transmission_Created_Event_When_Transmission_Is_Added and updated existing tests to account for the new transmission event.
tests/Digdir.Domain.Dialogporten.Application.Unit.Tests/Features/V1/Common/Utils/ApplicationEventHandlerUtilsTests.Developer_Should_Use_Caution_When_Modifying_Endpoints.verified.txt and
tests/Digdir.Domain.Dialogporten.Application.Unit.Tests/Features/V1/Common/Utils/ApplicationEventHandlerUtilsTests.Developer_Should_Use_Caution_When_Modifying_Events.verified.txt		 Updated test files to include DialogTransmissionCreatedDomainEvent in the list of dialog events being validated.

Possibly related PRs

  • feat: Restore dialog action #1702: Introduces similar modifications in the DialogEventToAltinnForwarder class by adding new event handling methods, indicating a strong code-level connection.

Suggested reviewers

  • MagnusSandgren
  • arealmaas
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5f09db and b9afb2c.

📒 Files selected for processing (1)
  • src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/Transmissions/DialogTransmission.cs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/Transmissions/DialogTransmission.cs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@oskogstad oskogstad merged commit ae0f7dc into main Feb 17, 2025
23 checks passed
@oskogstad oskogstad deleted the feat/transmission-created-event branch February 17, 2025 07:43
@dialogporten-bot dialogporten-bot mentioned this pull request Feb 16, 2025
Merged
oskogstad pushed a commit that referenced this pull request Feb 17, 2025
@dialogporten-bot
chore(main): release 1.51.0 (#1891)
19a9984 
🤖 I have created a release *beep* *boop*
---


##
[1.51.0](v1.50.9...v1.51.0)
(2025-02-17)


### Features

* Add event for transmission created
([#1893](#1893))
([ae0f7dc](ae0f7dc))


### Bug Fixes

* **webapi:** Mask unauthorized attachment URLs in EndUser transmission
endpoints ([#1890](#1890))
([f2f817b](f2f817b))


### Miscellaneous Chores

* **ci:** Always push new container version tags on release
([#1887](#1887))
([7d31b3b](7d31b3b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MagnusSandgren MagnusSandgren MagnusSandgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskogstad @MagnusSandgren