Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql): Upgrade to HotChocolate v15 #1640

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

oskogstad
Copy link
Collaborator

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Copy link
Contributor

coderabbitai bot commented Dec 27, 2024

📝 Walkthrough

Walkthrough

This pull request introduces several enhancements to the GraphQL functionality, including new enum types and directives for improved authorization control and scalar documentation. It updates package references in multiple project files to newer major versions of HotChocolate and related libraries. Additionally, the GraphQL server configuration is modified by replacing the direct registration of DbContext with a factory and adjusting cost options.

Changes

File(s) Change Summary
docs/schema/V1/schema.verified.graphql Added ApplyPolicy enum and directives @authorize (with parameters for policy, roles, and application phase) and @specifiedBy (for scalars).
src/.../Dialogporten.GraphQL.csproj
src/.../Infrastructure.csproj
Updated package references: upgraded AppAny.HotChocolate.FluentValidation (0.11.2 → 0.12.0) and HotChocolate packages including Subscriptions.Redis (13.9.14 → 15.0.0).
src/.../ServiceCollectionExtensions.cs Modified AddDialogportenGraphQl: removed direct DbContext registration, added DbContextFactory registration, and disabled default cost options.

Possibly related PRs

Suggested reviewers

  • MagnusSandgren
  • arealmaas

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be91ef4 and 48f9761.

📒 Files selected for processing (1)
  • src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Digdir.Domain.Dialogporten.Infrastructure/Digdir.Domain.Dialogporten.Infrastructure.csproj
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Dry run deploy apps / Deploy service to test
  • GitHub Check: Dry run deploy apps / Deploy web-api-so to test
  • GitHub Check: Dry run deploy apps / Deploy web-api-eu to test
  • GitHub Check: build / build-and-test

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Jan 2, 2025

@oskogstad oskogstad marked this pull request as ready for review February 4, 2025 20:34
@oskogstad oskogstad requested a review from a team as a code owner February 4, 2025 20:34
@oskogstad oskogstad changed the title chore(graphql): Upgrade to HotChocolate v14 chore(graphql): Upgrade to HotChocolate v15 Feb 4, 2025
knuhau
knuhau previously approved these changes Feb 5, 2025
@oskogstad oskogstad merged commit eeafaf4 into main Feb 5, 2025
23 checks passed
@oskogstad oskogstad deleted the chore/upgrade-to-graphql-14 branch February 5, 2025 13:25
oskogstad pushed a commit that referenced this pull request Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.48.4](v1.48.3...v1.48.4)
(2025-02-05)


### Miscellaneous Chores

* **dev:** Downgrade local Grafana to match Azure version
([#1807](#1807))
([01ab68d](01ab68d))
* **graphql:** Upgrade to HotChocolate v15
([#1640](#1640))
([eeafaf4](eeafaf4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants